Skip to content

sqlite: Drop media table from event cache store#5655

Merged
andybalaam merged 1 commit intomatrix-org:mainfrom
zecakeh:sqlite-rm-event-cache-media
Sep 11, 2025
Merged

sqlite: Drop media table from event cache store#5655
andybalaam merged 1 commit intomatrix-org:mainfrom
zecakeh:sqlite-rm-event-cache-media

Conversation

@zecakeh
Copy link
Collaborator

@zecakeh zecakeh commented Sep 11, 2025

Since the media store was split into a separate database in #5568.

Since the media store was split into a separate database.

Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
@zecakeh zecakeh requested a review from a team as a code owner September 11, 2025 10:10
@zecakeh zecakeh requested review from andybalaam and removed request for a team September 11, 2025 10:10
@codecov
Copy link

codecov bot commented Sep 11, 2025

Codecov Report

❌ Patch coverage is 60.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.34%. Comparing base (878e02b) to head (4706b45).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
crates/matrix-sdk-sqlite/src/event_cache_store.rs 60.00% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5655   +/-   ##
=======================================
  Coverage   88.34%   88.34%           
=======================================
  Files         354      354           
  Lines       97097    97107   +10     
  Branches    97097    97107   +10     
=======================================
+ Hits        85778    85793   +15     
+ Misses       7266     7258    -8     
- Partials     4053     4056    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codspeed-hq
Copy link

codspeed-hq bot commented Sep 11, 2025

CodSpeed Performance Report

Merging #5655 will improve performances by 47.79%

Comparing zecakeh:sqlite-rm-event-cache-media (4706b45) with main (878e02b)

Summary

⚡ 1 improvement
✅ 48 untouched

Benchmarks breakdown

Benchmark BASE HEAD Change
Restore session [memory store] 402.2 ms 272.1 ms +47.79%

Copy link
Member

@andybalaam andybalaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@andybalaam andybalaam merged commit 90eb403 into matrix-org:main Sep 11, 2025
53 checks passed
@zecakeh zecakeh deleted the sqlite-rm-event-cache-media branch September 11, 2025 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants