Part 2 of Split media store from event cache store#5569
Merged
dragonfly1033 merged 3 commits intodragonfly1033/split_media_dbfrom Sep 3, 2025
Merged
Part 2 of Split media store from event cache store#5569dragonfly1033 merged 3 commits intodragonfly1033/split_media_dbfrom
dragonfly1033 merged 3 commits intodragonfly1033/split_media_dbfrom
Conversation
dragonfly1033
force-pushed
the
dragonfly1033/split_media_db_2
branch
from
10bcf5c to
745891b
Compare
8 tasks
dragonfly1033
force-pushed
the
dragonfly1033/split_media_db
branch
from
561c12e to
cef5dd3
Compare
dragonfly1033
force-pushed
the
dragonfly1033/split_media_db_2
branch
from
745891b to
79160d6
Compare
dragonfly1033
requested review from
Hywan and
bnjbvr
and removed request for
a team and
bnjbvr
Hywan
reviewed
Sep 2, 2025
crates/matrix-sdk-base/src/event_cache/store/media/integration_tests.rs
Outdated
Show resolved
Hide resolved
dragonfly1033
force-pushed
the
dragonfly1033/split_media_db
branch
from
cef5dd3 to
7d3c4ad
Compare
dragonfly1033
force-pushed
the
dragonfly1033/split_media_db_2
branch
from
79160d6 to
aa0cf8b
Compare
added 2 commits
September 3, 2025 12:54
Split `MemoryMediaStore` from `MemoryStore`. Split `IndexeddbMediaStore` from `IndexxeddbEventCacheStore`.
dragonfly1033
force-pushed
the
dragonfly1033/split_media_db
branch
from
7d3c4ad to
11fc140
Compare
dragonfly1033
force-pushed
the
dragonfly1033/split_media_db_2
branch
from
aa0cf8b to
2f5de97
Compare
Hywan
approved these changes
Sep 3, 2025
Part 3 of Split media store from event cache store
dragonfly1033
added a commit
that referenced
this pull request
Sep 3, 2025
Part 2 of Split media store from event cache store
dragonfly1033
added a commit
that referenced
this pull request
Sep 3, 2025
Part 2 of Split media store from event cache store
dragonfly1033
pushed a commit
that referenced
this pull request
Sep 3, 2025
CodSpeed Performance ReportMerging #5569 will not alter performanceComparing Summary
Footnotes |
dragonfly1033
pushed a commit
that referenced
this pull request
Sep 3, 2025
dragonfly1033
pushed a commit
that referenced
this pull request
Sep 3, 2025
dragonfly1033
added a commit
that referenced
this pull request
Sep 9, 2025
Part 2 of Split media store from event cache store
Hywan
pushed a commit
that referenced
this pull request
Sep 10, 2025
This PR is a start to the process of splitting the media store from the event cache store. #5410 It contains: * Split `MediaStore` trait from `EventCacheStore`. * Rename `EventCacheStoreMedia` to `MediaStoreInner`. * Move relevant tests into `MediaStoreIntegrationTests`. This will be done over 3 PR's (reviewing 1, 2, 3 then merging 3 into 2 into 1). A reminder comment for my own sanity: This PR will not pass tests until after merging. Current state of this PR: - [x] Step 1 reviewed #5568 - [x] Step 2 reviewed #5569 - [x] Step 3 reviewed #5571 - [x] Step 3 merged into Step 2 - [x] Step 2 merged into Step 1 - [ ] Add changes to changelog. - [ ] Ready to merge 🎉 Note, may also want to: * Re-organize file structure * Split/refactor benchmarks namely `benchmarks/benches/event_cache.rs` <!-- description of the changes in this PR --> - [ ] Public API changes documented in changelogs (optional) <!-- Sign-off, if not part of the commits --> <!-- See CONTRIBUTING.md if you don't know what this is --> Signed-off-by: Shrey Patel shreyp@element.io --------- Co-authored-by: Shrey Patel <shreyp@element.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Read #5568 . This is part 2.
Contains:
SqliteMediaStorefromSqliteEventCacheStore.MemoryMediaStorefromMemoryStore.IndexeddbMediaStorefromIndexxeddbEventCacheStore.Reminder for my own sanity:
Do not merge until part 3 #5571 is merged.
Signed-off-by: Shrey Patel shreyp@element.io