Skip to content

Part 3 of Split media store from event cache store #5570

Closed
dragonfly1033 wants to merge 3 commits intomainfrom
dragonfly1033/split_media_db_3
Closed

Part 3 of Split media store from event cache store #5570
dragonfly1033 wants to merge 3 commits intomainfrom
dragonfly1033/split_media_db_3

Conversation

@dragonfly1033
Copy link
Contributor

Read #5568 . This is part 3.

Contains:

  • Instantiate MediaStores and use where required.
  • Public API changes documented in changelogs (optional)

Signed-off-by: Shrey Patel shreyp@element.io

Rename `EventCacheStoreMedia` to `MediaStoreInner`.
Move relevant tests into `MediaStoreIntegrationTests`.
@codspeed-hq
Copy link

codspeed-hq bot commented Aug 22, 2025

CodSpeed Performance Report

Merging #5570 will not alter performance

Comparing dragonfly1033/split_media_db_3 (280849b) with main (4e2655a)

Summary

✅ 37 untouched benchmarks

Shrey Patel added 2 commits August 22, 2025 15:30
Split `MemoryMediaStore` from `MemoryStore`.
Split `IndexeddbMediaStore` from `IndexxeddbEventCacheStore`.
@dragonfly1033 dragonfly1033 force-pushed the dragonfly1033/split_media_db_3 branch from 280849b to f7e029a Compare August 22, 2025 14:33
@dragonfly1033
Copy link
Contributor Author

dragonfly1033 commented Aug 22, 2025

Closed because it should be PR'd off Part 2 not main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant