Part 3 of Split media store from event cache store #5570
Closed
dragonfly1033 wants to merge 3 commits intomainfrom
Closed
Part 3 of Split media store from event cache store #5570dragonfly1033 wants to merge 3 commits intomainfrom
dragonfly1033 wants to merge 3 commits intomainfrom
Conversation
Rename `EventCacheStoreMedia` to `MediaStoreInner`. Move relevant tests into `MediaStoreIntegrationTests`.
CodSpeed Performance ReportMerging #5570 will not alter performanceComparing Summary
|
added 2 commits
August 22, 2025 15:30
Split `MemoryMediaStore` from `MemoryStore`. Split `IndexeddbMediaStore` from `IndexxeddbEventCacheStore`.
280849b to
f7e029a
Compare
Contributor
Author
|
Closed because it should be PR'd off Part 2 not main |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Read #5568 . This is part 3.
Contains:
MediaStores and use where required.Signed-off-by: Shrey Patel shreyp@element.io