Repository navigation
Repair Bring your history startup, page import verification and web checks - #33389
Conversation
Repair the Bring your history app compile and typed test fixture strings. Co-authored-by: Codex <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-0c925fb354ebca69d821
Co-authored-by: Codex <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-0c925fb354ebca69d821
Co-authored-by: Codex <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-0c925fb354ebca69d821
|
Found 10 test failures on Blacksmith runners: Failures
|
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Passes: CI passes on CI passes on Written by
|
Co-authored-by: Codex <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-0c925fb354ebca69d821
… input Co-authored-by: Codex <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-0c925fb354ebca69d821
Co-authored-by: Codex <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-0c925fb354ebca69d821
|
Review (subagent claude-opus-5-5 medium): SHIP at 53dcae0 First-run routing shows the page once (first workspace, no saved windows; upgrades record the flag without opening it; HistoryFirstRunRoutingTests cover all three); no launch scan of Downloads/Desktop (the test-zip hook is DEBUG-only and HOME-bound with a symlink-escape test); Skip/Done and the Home memory offer unchanged; Swift thin. Fleet DEV build: fresh-home page shown, ChatGPT export imported through the page, Chief read back the imported facts, not shown again on restart. Follow-ups: retry the offer if the first-run page fails to open. |
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
#33389 repairs the Bring your history stack on #33215. First-run presentation now opens as a top page, independent of Home pane replacement, and records the once-only flag only after presentation succeeds. The failed launch had logged a page creation against an unknown pane; its log did not identify which page. The new route avoids that race.
The repair also disambiguates the Chief CLI JSON parser, fixes the two unknown-value lint expressions, restores the missing gallery id and four grid-expanded fixtures, and removes three pointing-hand cursors. The sticky footer uses the opaque surface token. Existing base test repairs are carried forward for hidden shimmer text, Session Info expectations, preview controls, font/scroll trace setup, and the six-way visual-audit split; coverage is preserved.
DEBUG verification uses an explicitly supplied regular ZIP resolved beneath HOME, after the normal native gesture check. Native Chromium input reaches its actual page window through AppKit; DOM waits have bounded observer cleanup and matching transport deadlines.
User request: “Find why the fresh-home launch at your repair head showed Home without the Bring your history page (routing bug in #33215, or harness isolation), fix it on #33389 if ours, also fix #33215's two lint errors, the missing-gallery failure and the four grid-expanded browser cases, then on a fleet DEV build verify: page shown once on fresh home, ChatGPT export zip imported through the page, Chief memory readback, Done state captured. Reply with head, results, captures; stop.” Do not merge.
Validation at 53dcae0:
Prior art carried for test fixtures: #32953, #32965, #32946, #33124, #32955, #32939 (section-order assertion only), #32940, #33135, #33185. These are repairs already on base, not new product behavior.
No merge requested or performed.
🤖 Generated with Codex
Agent session: agent session