Repository navigation
base red: the fold-stream upward-anchor trace starts off the very bottom (#32644 fix forward) - #33135
Conversation
…x forward) "received card folds preserve painted row-box adjacency while streaming" scrolled the received card to the top of the view, which in the last turns of the fixture is the physical end. Since #32644 (Leo, 2026-11-02: "YOU EXPAND UP WHILE YOUR SCCROLL IS AT THE VERY BOTTOM ... JUST THAT CASE"), opening a line there pushes the text above it up: the card's top moves 1164px up on purpose, the oracle counts that as drift and missing anchors, and the following close lands past the end for three blank frames. #32644 moved the other keep-place tests off the bottom; this one was missed. Start the trace 48px up from the end, as agent-pane-fold-keeps-place does, so it again checks a fold that keeps its place while the reply streams. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-2f629b93d5a20c58e6f8
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Shipped in:
|
…nistically Wait for fonts before placing the card, and never move the start further down than where scrollIntoView put it, so the card stays in view whether or not scrollIntoView landed on the physical end. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-2f629b93d5a20c58e6f8
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
|
Review (subagent opus-5.5 medium): SHIP at eece95f Visual verdict: unchanged by this diff (test only). Checked the cause: the collapsed received card sits 8 short rows from the end, so Green 3/3 in one step at this head, fmt clean: https://github.com/manaflow-ai/cmux/actions/runs/41601762114 Follow-ups:
|
Summary
webviews/test/transcript-upward-anchor.test.ts"received card folds preserve painted row-box adjacency while streaming" is red on everycmux-next webpush run onfeat-cmux-next(expect(result.compared).toBe(result.frames): 130 or 132 of 136), for example run 41581500665 at 53921ff, job "web / react-apps-check (8)".Cause
The test scrolls the received card (
gap-incoming, in the fixture's last turns) to the top of the view. Its content below is shorter than the view, so that lands at the transcript's physical end. Since #32644, opening a line at the very bottom deliberately pushes the text above it up (Leo, 2026-11-02: "YOU EXPAND UP WHILE YOUR SCCROLL IS AT THE VERY BOTTOM AKA YOU PUSH THE TEXT UP VISUALLY INSTEAD OF EXPANDING DOWN LIKE USUAL / JUST THAT CASE"), and #32943 holds the rows under the opened line with a clip on what rises. In the trace'stranscript-fold-stream:line that shows up as:scrollTop745119 to 746283, and the card's top goes from 15.75 to -1148 (drift -1164, missing anchors), with two frames where the clipped card's box overlaps the held rows by 1148px (getBoundingClientRectignores the clip);That is the push-up behaviour #32644 asked for, seen by an oracle that expects the line to keep its place. #32644 already moved the other keep-place tests off the bottom (
agent-pane-fold-keeps-place.test.ts,received-message-fold-browser.test.ts); this trace was missed.Fix
Test only. Before the trace, put the view 48px up from the end, the same way
agent-pane-fold-keeps-place.test.tsdoes, and assert it is more than 8px from the end. The trace again checks what it was written for (#27365): a received card that folds in place while the last reply streams, with no drift, gaps, overlaps or blank frames. The very-bottom push-up keeps its own coverage intranscript-expand-at-bottom.test.ts.Base-red-job: web / react-apps-check
Changelog
none
Observed / Not run
Expected: 136,Received: 130; runs 41580824945 and 41580790250 the same way.cmux-ci test --setup webviews -- bash scripts/ci/run-webviews-tests.sh test/transcript-upward-anchor.test.ts(run 41590121087, PASS), thenbun test test/transcript-upward-anchor.test.tstwice in one step (run 41591800362): 7 pass, 0 fail each time, the fold-stream test included.Agent session: agent session
🤖 Generated with Claude Code