Repository navigation
base red: grid-lines measures Session Info in #32850's order, without #32817's hidden fold - #32965
Conversation
… trail line for #32817's hidden fold Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-2f629b93d5a20c58e6f8
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Shipped in:
|
|
Review (subagent opus-5.5 medium): SHIP at f1ead67 Checked that #32817 (the fold chevron after the title, hidden at rest) and #32850 (the new DEFAULT_ORDER) changed these things on purpose. Checked that the new block pairs pick the first and last slot of each run (usage→subagents, tasks→sources, outputs→connectors) under gridLines.ts Follow-ups:
|
webviews/test/browser/grid-lines.test.ts:146fails on base (runs 41568146239 at 7d8ae70, 41568701123 at 68fbf49) in all foursession-info/grid-expandedscenes. Two merged PRs changed Session Info on purpose, and the scene still measured the old layout:visibility: hiddenat rest (cmux#32765). The scene'ssection headings: trail cxline still looked for it on the trailing column, so it reportedmissing visible selector .acpmux-session-info-section__foldas a coverage failure. That line is removed.SessionInfo.gallery.tsx(chevronOnHoverAfterTitle, from Session Info: the page draws it by default again, with the native panel's header buttons (held for Leo) #32817) already checks where the chevron sits and that it shows on hover.usage to connectors(inner gap: got 1236, expected 12),about to madeandmade to running(block gaps: got 548 and -1188, expected 24) measured pairs that are no longer next to each other. The inner-gap pairs are now the about block's adjacent ones (environment to context, context to usage). The block-gap pairs are the runs the new order draws: about to running, running to made, and made to about (Connectors).Only the test changes, no product code. Both PRs changed the behaviour on purpose.
Base-red-job: web / react-apps-check
Regressing PRs: #32817, #32850
Tests: this PR's
web / react-apps-check(grid-lines shard).Agent session: agent session
🤖 Generated with Claude Code
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Updates the grid-lines test scene so Session Info measurements match the behavior from #32817 and #32850, fixing a failure in all four
session-info/grid-expandedscenes on base.Only the test changes; no product code.
Written for commit f1ead67. Summary will update on new commits.