Skip to content

base red: grid-lines measures Session Info in #32850's order, without #32817's hidden fold - #32965

Merged
cmux-bot[bot] merged 1 commit into
feat-cmux-nextfrom
lane/web-base-red-grid-lines-si
Nov 3, 2026
Merged

cmux-bot[bot] merged 1 commit into
feat-cmux-nextfrom
lane/web-base-red-grid-lines-si

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Nov 3, 2026 •

Copy link
Copy Markdown
Collaborator

webviews/test/browser/grid-lines.test.ts:146 fails on base (runs 41568146239 at 7d8ae70, 41568701123 at 68fbf49) in all four session-info/grid-expanded scenes. Two merged PRs changed Session Info on purpose, and the scene still measured the old layout:

Only the test changes, no product code. Both PRs changed the behaviour on purpose.

Base-red-job: web / react-apps-check
Regressing PRs: #32817, #32850

Tests: this PR's web / react-apps-check (grid-lines shard).

Agent session: agent session

🤖 Generated with Claude Code


Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Updates the grid-lines test scene so Session Info measurements match the behavior from #32817 and #32850, fixing a failure in all four session-info/grid-expanded scenes on base.

Only the test changes; no product code.

Written for commit f1ead67. Summary will update on new commits.

View guided diff Turn on auto-fix

… trail line for #32817's hidden fold

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-2f629b93d5a20c58e6f8
@cursor

cursor Bot commented Nov 3, 2026

Copy link
Copy Markdown

Bugbot needs on-demand usage enabled

Bugbot uses usage-based billing for this team and requires on-demand usage to be enabled.

A team admin can enable on-demand usage in the Cursor dashboard.

@github-actions

github-actions Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review f1ead67: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr32965 -f ref=lane/web-base-red-grid-lines-si -f platform=macos -f backend_mode=local

Shipped in:

@github-actions github-actions Bot added the risk:low Risk tier (docs/ci/risk-tiers.md) label Nov 3, 2026
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (subagent opus-5.5 medium): SHIP at f1ead67
Visual verdict: unchanged by this diff (test-only)

Checked that #32817 (the fold chevron after the title, hidden at rest) and #32850 (the new DEFAULT_ORDER) changed these things on purpose. Checked that the new block pairs pick the first and last slot of each run (usage→subagents, tasks→sources, outputs→connectors) under gridLines.ts select's first-match rule. Checked that the remaining inner pairs are still adjacent. The diff changes only the test and hides no product regression.

Follow-ups:

  • [follow-up] With the fold's trail line gone, nothing measures the exact one-grid-gap distance from the title to the chevron. chevronOnHoverAfterTitle only checks that the chevron comes after the title.

@cmux-bot
cmux-bot Bot merged commit 166f1dc into feat-cmux-next Nov 3, 2026
162 of 173 checks passed
@cmux-bot
cmux-bot Bot deleted the lane/web-base-red-grid-lines-si branch November 3, 2026 04:44

This branch was previously deployed

1 inactive deployment
ci-routing-agent — f1ead671 Deployed Nov 3, 2026 by teamleaderleo via cmux-tui tree preflight #103773
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:low Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant