Skip to content

base red: accent-glass invariants scan in six parts, so part 3 fits its 480 s limit - #33185

Merged
teamleaderleo merged 1 commit into
feat-cmux-nextfrom
lane/react-apps-6-red
Nov 3, 2026
Merged

teamleaderleo merged 1 commit into
feat-cmux-nextfrom
lane/react-apps-6-red

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Nov 3, 2026 •

Copy link
Copy Markdown
Collaborator

Base red: react-apps-check (6) (CI and cmux-next web) fails on feat-cmux-next. The newest failing base run is 41586011973. In that run test/accent-glass-invariants-3.test.ts hit its 480 s file limit at stage 750 of 879, and timed out again when retried alone.

The gallery now has about 3,500 accent-glass stages, so each of the four parts scanned about 879. This splits the scan into six parts of about 586 stages each, under the same 480 s limit, by adding -5 and -6 and setting parts: 6 in every part. Coverage is unchanged: part N scans the stages where index % 6 == N-1, so every stage is scanned exactly once.

Other shard-6 reds from earlier base runs come from other files (message-preview-browser, session-info-overlay-toggle, transcript-upward-anchor). Those are separate base reds that the duration split happened to place in shard 6; this PR does not touch them.

Changelog

none

Observed / Not run

  • Observed: the base job logs for runs 41586011973, 41585300286 and 41584419316; a subagent review gave SHIP.
  • Not run: the accent-glass files locally (they are browser and dev-server files). This PR's own react-apps-check is the run.

risk:low (test only)

Agent session: agent session

🤖 Generated with Claude Code


Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Splits the accent-glass invariants scan from four parts to six so each part stays under the 480 s file limit in react-apps-check (6).

  • Part 3 of 4 timed out at stage 750 of 879 even when retried alone (run 41586011973).
  • Adds parts 5 and 6 and sets parts: 6 in all parts; each part now scans about 586 stages instead of 879.
  • Coverage is unchanged: each part scans every parts-th stage, so every stage is scanned exactly once.
  • Other shard-6 reds (message-preview-browser, session-info-overlay-toggle, transcript-upward-anchor) are separate base reds and are not touched.

Written for commit 666a73f. Summary will update on new commits.

View guided diff Turn on auto-fix

The gallery grew to about 3,500 accent-glass stages, so each of four parts
scanned about 879 and part 3 ran past its 480 s file limit even when retried
alone (run 41586011973, react-apps-check (6) red on the feat-cmux-next base).
Six parts of about 586 stages each fit the limit again.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-a1e915138c60810a8b78
@github-actions

github-actions Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review 666a73f: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr33185 -f ref=lane/react-apps-6-red -f platform=macos -f backend_mode=local

Shipped in:

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (subagent opus-5.5 medium, correctness first): SHIP at 666a73f
Visual verdict: unchanged by this diff (test only).
Checked: parts 1-6 together cover every stage exactly once (index % 6). Baseline ownership (ownedHere) and the orange-theme and 90% floors are each counted per part. The new files are detected as dev-server files by their vite.config marker and placed in a shard by a hash of their path. No hard-coded list of the part files exists.
Follow-ups: the duration manifest keeps the old per-part times until the next base push refreshes it; that only skews shard balance.

@github-actions github-actions Bot added the risk:low Risk tier (docs/ci/risk-tiers.md) label Nov 3, 2026
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (codex, router-review): SHIP at 666a73f

Reviewer: codex gpt-6.1-sol xhigh, fast tier.

Follow-ups: 1. Each lands as an issue in this repo that links this receipt; the lane that opened the PR fixes it forward.

SHIP at 666a73f
Visual verdict: no images; Leo tries the build

Checked complete, disjoint stage coverage and CI discovery statically. Browser tests could not run here.

Follow-ups:

  1. [P2] [follow-up] webviews/test/accent-glass-invariants-5.test.ts:7: After images are unavailable; visual verification remains pending.

@cmux-bot cmux-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cmux-bot approves 666a73f: an independent review passed this exact head (router-review receipt by teamleaderleo). A push needs a new review; a later BLOCK at this head dismisses this approval.

@teamleaderleo
teamleaderleo merged commit 02412c5 into feat-cmux-next Nov 3, 2026
167 of 176 checks passed
@teamleaderleo
teamleaderleo deleted the lane/react-apps-6-red branch November 3, 2026 08:23

This branch was previously deployed

1 inactive deployment
ci-routing-agent — 666a73f0 Deployed Nov 3, 2026 by teamleaderleo via cmux-tui tree preflight #104395
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:low Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant