Skip to content

base red: message-preview closes the open sent row from its chevron - #32940

Merged
cmux-bot[bot] merged 4 commits into
feat-cmux-nextfrom
lane/web-base-red-message-preview-2
Nov 3, 2026
Merged

cmux-bot[bot] merged 4 commits into
feat-cmux-nextfrom
lane/web-base-red-message-preview-2

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Nov 3, 2026 •

Copy link
Copy Markdown
Collaborator

Base-red-job: web / react-apps-check

Follow-up to #32823. webviews/test/message-preview-browser.test.ts:137 is still red on base with "TimeoutError: click: Timeout 5000ms exceeded" on .cv-message .cv-agentmsg__toggle. Playwright reports "element is not visible" (runs 41568146239 at 7d8ae70 and 41568701123 at 68fbf49).

Cause: #32867 (cd8e520, "every disclosure chevron sits right after its label") landed 3 minutes after #32823. In the transcript it makes a message line's toggle button flex: 0 1 auto and puts its sentence in display: contents. While the row is open, the button holds an empty preview ({open ? "" : preview}, AgentMessageRow.tsx), so it is 0px wide. Line 137 clicks that button to close the open sent row. #32823 itself did not cause this: the sent test does not depend on the "Received N messages" row.

Fix: the test closes the open row from its chevron (.cv-agentmsg__chevron). That is what a person clicks, and the whole line still toggles through headerToggleClick. Test-only; #32867's layout is the intended design.

Follow-up (not blocking): the open sent row's toggle button is still the keyboard control, and at 0px wide its focus ring draws nothing.

Observed / Not run

  • cmux-ci test -- bash -c "cd webviews && bun test test/message-preview-browser.test.ts": red before the fix (base plus the earlier scoped-open attempt, 568233b; run 41572929364): 4 pass, 1 fail, sent test "click: Timeout 5000ms exceeded", element not visible. Green at this head e5f05ab (run 41573362366): 5 pass, 0 fail.
  • Not run: the full webview suite locally (lane VM); PR CI runs it.

Changelog

none

Agent session: agent session

🤖 Generated with Claude Code

@github-actions

github-actions Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review e5f05ab: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr32940 -f ref=lane/web-base-red-message-preview-2 -f platform=macos -f backend_mode=local

Passes: CI passes on d60d3508e4.

CI passes on d60d3508e4 (run 41624415202 attempt 1).

Written by scripts/ci/classify_failures.py (ci-failure-attribution.yml); signatures are its SIGNATURES table. A machine verdict is the runner's fault, not this PR's; yours means the failing file is one this PR changes, also red on main that main's latest full suite fails the same way, seen on other PRs that it failed on another pull request's run lately.

web and size checks: green

Shipped in:

@github-actions github-actions Bot added the risk:low Risk tier (docs/ci/risk-tiers.md) label Nov 3, 2026
…vron

Line 137 of message-preview-browser.test.ts clicked the sent row's
toggle button while the row was open ("click: Timeout 5000ms exceeded",
"element is not visible"; runs 41568146239 and 41568701123). Since
#32867 (cd8e520) a transcript message line's toggle is flex 0 1 auto,
and open it holds an empty preview, so it has no width. The whole line
still toggles (headerToggleClick), so the test closes it from the
chevron, which the person sees and clicks.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-2f629b93d5a20c58e6f8
@teamleaderleo
teamleaderleo force-pushed the lane/web-base-red-message-preview-2 branch from 568233b to e5f05ab Compare November 3, 2026 03:37
@teamleaderleo teamleaderleo changed the title base red: message-preview opens the Received row only for the received tests base red: message-preview closes the open sent row from its chevron Nov 3, 2026
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (subagent opus-5.5 medium): SHIP at e5f05ab

Visual verdict: unchanged by this diff (test-only).

Checked: since #32867 the open sent toggle is 0px wide (flex 0 1 auto, sentence display: contents, empty preview while open). The 12px chevron is visible, matches one element in cards-no-fade, and toggles the line through headerToggleClick. No other step clicks an open message toggle.

Follow-ups: the open sent row's toggle draws no focus ring at 0px (product, from #32867).

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (codex gpt-6.1-sol high, sweep, via the review router; full diff from merge base b1e9206 to this head): SHIP at af50546

No P1/P2 findings.

@cursor

cursor Bot commented Nov 3, 2026

Copy link
Copy Markdown

Bugbot needs on-demand usage enabled

Bugbot uses usage-based billing for this team and requires on-demand usage to be enabled.

A team admin can enable on-demand usage in the Cursor dashboard.

@blacksmith-sh

blacksmith-sh Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Found 1 test failure on Blacksmith runners:

Failure

Test View Logs
test_every_compile_job_names_its_warm_sources (main.ThisTree.test_every_compile_job
_names_its_warm_sources)/
test_every_compile_job_names_its_warm_sources (main.ThisTree.test_every_compile_job
_names_its_warm_sources)
View Logs

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Merged feat-cmux-next into this branch: the head is now cc63754. Against base, the PR diff is still only webviews/test/message-preview-browser.test.ts (+3/−1), unchanged since the reviewed e5f05ab.

Why the merge: shard 1 of the web suite was cancelled at the 40-minute job limit twice at the old head, so no webview verdict could be published. #33150 (91da02a) fixed the shard balance on base, so CI on this head should finish under the limit.

The review carries: Review (subagent opus-5.5 medium): SHIP at cc63754e10ed5ad7e7f42bf923e37973e7d372d6 (the delta from e5f05ab is base merges only).

@cmux-bot
cmux-bot Bot temporarily deployed to ci-routing-agent November 3, 2026 11:03 Inactive
@cmux-bot
cmux-bot Bot temporarily deployed to ci-routing-agent November 3, 2026 11:07 Inactive
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (next-review patch-id; carried): SHIP at d60d350

The independent SHIP at af50546 carries to this head: the PR's own change (git diff $(git merge-base feat-cmux-next HEAD) HEAD) has the same git patch-id --verbatim (4b94d08de6c09561) at both heads, and no merge between them was resolved by hand. Nothing new to review. A newer BLOCK, or any change to the PR's own diff, ends the carry.

@cmux-bot
cmux-bot Bot merged commit 295594d into feat-cmux-next Nov 3, 2026
142 of 145 checks passed
@cmux-bot
cmux-bot Bot deleted the lane/web-base-red-message-preview-2 branch November 3, 2026 12:21

This branch was previously deployed

1 inactive deployment
ci-routing-agent — d60d3508 Deployed Nov 3, 2026 by cmux-bot[bot] via wait for same-key tree publisher #105667
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:low Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant