Repository navigation
base red: message-preview closes the open sent row from its chevron - #32940
Conversation
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Passes: CI passes on CI passes on Written by web and size checks: green Shipped in:
|
…vron
Line 137 of message-preview-browser.test.ts clicked the sent row's
toggle button while the row was open ("click: Timeout 5000ms exceeded",
"element is not visible"; runs 41568146239 and 41568701123). Since
#32867 (cd8e520) a transcript message line's toggle is flex 0 1 auto,
and open it holds an empty preview, so it has no width. The whole line
still toggles (headerToggleClick), so the test closes it from the
chevron, which the person sees and clicks.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-2f629b93d5a20c58e6f8
568233b to
e5f05ab
Compare
|
Review (subagent opus-5.5 medium): SHIP at e5f05ab Visual verdict: unchanged by this diff (test-only). Checked: since #32867 the open sent toggle is 0px wide (flex 0 1 auto, sentence display: contents, empty preview while open). The 12px chevron is visible, matches one element in cards-no-fade, and toggles the line through headerToggleClick. No other step clicks an open message toggle. Follow-ups: the open sent row's toggle draws no focus ring at 0px (product, from #32867). |
…se-red-message-preview-2
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
|
Found 1 test failure on Blacksmith runners: Failure
|
|
Merged feat-cmux-next into this branch: the head is now cc63754. Against base, the PR diff is still only Why the merge: shard 1 of the web suite was cancelled at the 40-minute job limit twice at the old head, so no webview verdict could be published. #33150 (91da02a) fixed the shard balance on base, so CI on this head should finish under the limit. The review carries: |
|
Review (next-review patch-id; carried): SHIP at d60d350 The independent SHIP at af50546 carries to this head: the PR's own change ( |
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
Base-red-job: web / react-apps-check
Follow-up to #32823.
webviews/test/message-preview-browser.test.ts:137is still red on base with "TimeoutError: click: Timeout 5000ms exceeded" on.cv-message .cv-agentmsg__toggle. Playwright reports "element is not visible" (runs 41568146239 at 7d8ae70 and 41568701123 at 68fbf49).Cause: #32867 (cd8e520, "every disclosure chevron sits right after its label") landed 3 minutes after #32823. In the transcript it makes a message line's toggle button
flex: 0 1 autoand puts its sentence indisplay: contents. While the row is open, the button holds an empty preview ({open ? "" : preview}, AgentMessageRow.tsx), so it is 0px wide. Line 137 clicks that button to close the open sent row. #32823 itself did not cause this: the sent test does not depend on the "Received N messages" row.Fix: the test closes the open row from its chevron (
.cv-agentmsg__chevron). That is what a person clicks, and the whole line still toggles throughheaderToggleClick. Test-only; #32867's layout is the intended design.Follow-up (not blocking): the open sent row's toggle button is still the keyboard control, and at 0px wide its focus ring draws nothing.
Observed / Not run
cmux-ci test -- bash -c "cd webviews && bun test test/message-preview-browser.test.ts": red before the fix (base plus the earlier scoped-open attempt, 568233b; run 41572929364): 4 pass, 1 fail, sent test "click: Timeout 5000ms exceeded", element not visible. Green at this head e5f05ab (run 41573362366): 5 pass, 0 fail.Changelog
none
Agent session: agent session
🤖 Generated with Claude Code