Repository navigation
ci: export npm_config_prefix where create-dmg is installed for resumed DMGs - #21311
Conversation
…d DMGs Same fix as #21310 on main: the install step set npm_config_prefix without export, so npm installed create-dmg outside $RUNNER_TEMP/npm-global and the wrapper failed (main auto-resume run 39009052594).
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…orted the prefix)
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
|
Correctness review (subagent): no BLOCKER, no SHOULD-FIX. Confirmed: the export makes npm install create-dmg under $RUNNER_TEMP/npm-global, where the wrapper looks; no unexported |
|
Bead |
|
The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/39016200396 at 187858c failed: cmux app scheme compile (Debug), cmux-next fast tier. |
…cx-q1lnl) 134 main commits since the last sync (3e7ed5a). Full rename detection (merge.renameLimit=100000). manaflow-ai#21310 (0d5316d, export npm_config_prefix) is now on main; it is a superset of feat's manaflow-ai#21311 copy, so the resume workflows keep one version (main's). No Swift, Rust, Go or package manifest change survives the merge (daemon/remote/go.mod unchanged). Conflict choices: - 209 modify/delete and 1 rename/delete in the legacy app, legacy CLI, cmuxTests, legacy Swift packages and Resources/Localizable.xcstrings: kept deleted. - cmux.xcodeproj/project.pbxproj, cmux.xcworkspace/contents.xcworkspacedata, docs/cli-contract.md, tests/test-execution.toml: feat-cmux-next's side. - ci-macos.yml, seed-derived-data.yml, restore-app-host-test-product.sh, package-test-lane.sh (CmuxTextActions), tests/test_ci_change_areas.py (app-host admission block): feat's side; main's rsync --no-times edits are for CmuxAgentJournal framework staging that feat deleted. Main's new merge-gate change-area test merged in. - scripts/ci/compile-app-host-test-product.sh: main's logic (the legacy cmux target builds without the compilation cache on every Xcode); the test (test_ci_test_compilation_cache_seed.sh) keeps feat's one-scheme checks with main's every-Xcode loop. - nightly.yml and tests/test_nightly_universal_build.sh: feat's side (feat already had manaflow-ai#21761's empty DerivedData start via manaflow-ai#21762, plus the nightly-next build-state prepare and its no-replay check; manaflow-ai#21544's promotion change was already on feat via manaflow-ai#21533). Feat's WRITER gate, live HOLD read, recovery guard, legacy-identity split, Mach-O floor, macOS 15 launch job and bash 3.2 parse hardening kept. - scripts/gh-merge-green: main's version (multiple freeze tokens manaflow-ai#21584, merge-tree merged head manaflow-ai#21576, missing Swift path refusal manaflow-ai#21560, risk evidence manaflow-ai#21692) plus feat's "cmux-next Swift canary" required check, freeze expiry and owner/pr/head metadata, and the canonical merged path. - scripts/install-cmux-tui-client.sh: union of the header comments (main's total download budget manaflow-ai#16305 and feat's attestation retry text). - web/data/cmux-shortcuts.ts: feat's generated table. - web/services/vms/workflows.ts: feat's doc comment on requireUserVm. - Run API: feat's version (manaflow-ai#21337, open lanes manaflow-ai#21634/manaflow-ai#21305 build on it). web/services/runs/*, web/app/api/runs/*, web/db/schema.ts run tables: feat's side. Main's parallel Run API (manaflow-ai#21444, manaflow-ai#21468, manaflow-ai#21473, manaflow-ai#21477, manaflow-ai#21484, manaflow-ai#21488, manaflow-ai#21492, manaflow-ai#21495, manaflow-ai#21467, manaflow-ai#21517, manaflow-ai#21573, manaflow-ai#21596) is NOT ported: its runs services, cron route and vercel.json cron, admission probe, run migrations 20261017150000/20261018000000/20261018110000/ 20261018120000 and their tests are removed here, and cloud-vm-dogfood.yml / dogfood-journey.mjs stay feat's (main's staging dogfood deploy changes manaflow-ai#21556-manaflow-ai#21617 and manaflow-ai#21424-manaflow-ai#21428 not ported). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Same fix as #21310 (main). The install steps set
npm_config_prefixwithoutexport, sonpm install --globalinstalled create-dmg outside$RUNNER_TEMP/npm-globaland the wrapper failed ("Cannot find module .../create-dmg/cli.js", main auto-resume run 39009052594).nightly.ymlalready exports it. 3 steps on feat-cmux-next.Changelog
none
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Exports
npm_config_prefixin the two resume-nightly-notarization workflows socreate-dmgis installed into$RUNNER_TEMP/npm-globaland the wrapper can find its CLI.export, so npm installed outside the prefix and the wrapper failed with "Cannot find module .../create-dmg/cli.js".nightly.yml.Written for commit 38b7580. Summary will update on new commits.