Skip to content

ci(next): retain exact frame pacing receipts - #21314

Merged
teamleaderleo merged 2 commits into
feat-cmux-nextfrom
perf/frame-pacing-receipt
Oct 17, 2026
Merged

teamleaderleo merged 2 commits into
feat-cmux-nextfrom
perf/frame-pacing-receipt

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 17, 2026 •

Copy link
Copy Markdown
Collaborator

Frame-pacing currently surfaces warnings but leaves no durable, source-bound measurement artifact. This change writes a machine-readable summary.json beside the raw fling data, bound to the exact resolved source SHA and workflow SHA.

The receipt records display status, per-mode median p50/p95 frame timings, dropped/total frames, thresholds, and regression annotations. Existing warning-only behavior is unchanged so unavailable GUI runners remain non-blocking while later ratchets have stable input.

Validation:

  • python3 tests/test_ci_frame_pacing_summary.py
  • python3 -m py_compile scripts/ci/frame-pacing/summarize.py
  • python3 tests/test_ci_frame_pacing_app_rpc.py
  • git diff --check

View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Writes a summary.json receipt beside the raw frame-pacing fling data, bound to the exact source and workflow SHAs that produced it.

  • Records display status, per-mode median p50/p95 timings, dropped/total frames, thresholds, and regression annotations.
  • Also writes a receipt for skipped runs (GUI token not acquired or gate skip), preserving the reason so skipped nights are distinguishable from missing artifacts.
  • Keeps the job warning-only, so unavailable GUI runners still don't block the run.

Written for commit a4337f1. Summary will update on new commits.

View guided diff Turn on auto-fix

@coderabbitai

coderabbitai Bot commented Oct 17, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: d7f6ee4b-a216-4fb5-82fe-46ca70f7e7f8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Bead cx-lhwjw created for this PR by the cmux coordinator.

@teamleaderleo
teamleaderleo merged commit f105039 into feat-cmux-next Oct 17, 2026
73 checks passed
@teamleaderleo
teamleaderleo deleted the perf/frame-pacing-receipt branch October 17, 2026 08:02
@github-actions

Copy link
Copy Markdown
Contributor

The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/39016200396 at 187858c failed: cmux app scheme compile (Debug), cmux-next fast tier.
Those jobs last passed at 793201f. This pull request is one of 2 merged since: #21314, #21311.
If the failure is in your change, fix forward on feat-cmux-next. Pull requests run only the tiers their paths reach (docs/ci/cmux-next-tiers.md); label a batch PR full-ci to run them all before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant