Repository navigation
test(remote): isolate tmux stale-surface fixture - #16566
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 11 minutes. View limit detailsLimit details: You’ve used all 10 included reviews currently available. Review configuration: ⚙️ Run configurationConfiguration used: Repository: manaflow-ai/cmux/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
All contributors have signed the CLA ✍️ ✅ |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
No issues found across 1 file
You’re at about 90% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.
|
Merge receipt for |
0bfd027 test(cloud): fix the Cloud header and moved-panel focus tests that never ran (manaflow-ai#16539) c5c4345 localization: accept numbered placeholders in any order (manaflow-ai#16376) 456edeb fix(settings): replace custom sidebar mockups with real previews (manaflow-ai#16569) 98dc3ab Prototype: cmux Cloud as a remote MCP server (manaflow-ai#16568) 6c22525 test(remote): isolate tmux stale-surface fixture (manaflow-ai#16566) 3ec9918 Re-land "fix(coderouter): initialize Cloud VM account pools (manaflow-ai#16397)" (manaflow-ai#16572) 2b895a5 Fix browser paste routing with terminal text box beta (manaflow-ai#6380) (manaflow-ai#16560) 2bd3455 localization: check Swift defaultValue literals against their catalog en value (manaflow-ai#16396) c43086e test(cli): expect --mark-read to mark every listed inbox message (manaflow-ai#16537) fcda4f0 test(feed): wait for zero-wait Codex permission acceptance before checking attention (manaflow-ai#16536) 7d57a03 fix(remote): evict stale persistent SSH bridge leases (manaflow-ai#16558) d630cb8 docs: add protected-folder diagnostics for tmux sessions (manaflow-ai#12219) 7dceaac test: create cwd fixtures that new terminals now resolve on disk (manaflow-ai#16538) 28cc575 docs: cover surface resume binding CLI contract (manaflow-ai#16473) 5c7dca1 Fix idle zsh PR probes triggering chpwd hooks (manaflow-ai#16553) # Conflicts: # .github/workflows/ci-guards.yml
1 participant
Problem
TestTmuxStaleInheritedSurfaceCannotRetargetinherited the caller's ambientTMUX_PANE. When the test ran from a tmux session, that unrelated pane did not match the fixture target, so the resolver selected the fixture's focused surface and the test failed with an unexpectedsurface.send_textorsurface.closecall.Fix
Set
TMUX_PANEto the fixture pane alongsideCMUX_PANE_ID, keeping the stale-surface case deterministic and preventing parent-session state from changing target resolution.Verification
go test ./cmd/cmuxd-remote -run '^TestTmuxStaleInheritedSurfaceCannotRetarget$' -count=1git diff --check— Teakettle g2 💾
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Isolates
TestTmuxStaleInheritedSurfaceCannotRetargetfrom the caller's ambient tmux session so the fixture's focused surface is always selected deterministically.Sets
TMUX_PANEto the fixture pane alongsideCMUX_PANE_ID, preventing parent-session state from changing target resolution and making the stale-surface case stable when run from tmux.Written for commit 1534c58. Summary will update on new commits.