test: create cwd fixtures that new terminals resolve on disk

[teamleaderleo]

Summary

#16248 changed RemoteTerminalWorkingDirectoryResolver on purpose. A missing local startup cwd now resolves to its nearest existing parent, so a restored agent cannot resume in another workspace's directory. Several tests passed made-up paths such as /tmp/cmux-split-startup-<uuid> or /repo/left/live to splits, new tabs, respawn and surface.create. Those paths now resolve to /tmp or /, so the tests failed.

The product change is intended and has its own coverage. This PR leaves it alone and makes the affected tests create their directories:

• WorkspaceTerminalWorkingDirectoryFallbackTests.newTerminalSurfaceFallsBackToRequestedWorkingDirectoryWhenReportedDirectoryIsStale
• WorkspaceSplitStartupCommandTests split and respawn tests
• WorkspaceTerminalTabWorkingDirectoryTests: Cmd+T after restore, new terminal to right, surface.create
• WorkspacePanelGitBranchTests.testSidebarBranchDirectoryEntriesStayStableAcrossFocusedSplitChanges, which showed the extra / entry

Testing

CI; no local build per team rule. swiftc -parse passes on each edited test file.

Changelog

none

🤖 Generated with Claude Code

https://claude.ai/code/session_01FrR7YbsQtGw2eFtDeyiTcK

---

^{Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.}

---

Summary by cubic

Fixes tests that broke after #16248, which changed RemoteTerminalWorkingDirectoryResolver to resolve a missing local startup cwd to its nearest existing parent. Tests passed made-up paths such as /tmp/cmux-split-startup-<uuid> or /repo/left/live, which now resolve to /tmp or / and fail. The affected tests now create their directories on disk before exercising splits, new tabs, respawn, surface.create, and the sidebar branch directory test. No product behavior changes.

^{Written for commit 2fdf4cc. Summary will update on new commits.}

[github-actions]

All contributors have signed the CLA ✍️ ✅
_{Posted by the CLA Assistant Lite bot.}

[coderabbitai]

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 7 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 10 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 3225b246-4a0e-48f8-bb8a-f948e55f88a4

📥 Commits

Reviewing files that changed from the base of the PR and between 8b8762a and 2fdf4cc.

📒 Files selected for processing (4)

• cmuxTests/WorkspaceSplitStartupCommandTests.swift
• cmuxTests/WorkspaceTerminalTabWorkingDirectoryTests.swift
• cmuxTests/WorkspaceTerminalWorkingDirectoryFallbackTests.swift
• cmuxTests/WorkspaceUnitTests.swift

• Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[teamleaderleo]

Subagent review at a2f4c9e: approve. #16248 intentionally resolves a missing local cwd to its nearest existing parent; see its test missingLocalRestoreDirectoryUsesItsNearestExistingParent. The resolver doesn't canonicalise symlinks, so the created temp dirs come back unchanged. Each defer cleanup is registered right after its create. The newly throws XCTest methods are still discovered. The sidebar test now asserts against real absolute temp dirs.

[github-actions]

CI failure attribution

CI passes on 2fdf4cc06a (run 36944182095 attempt 1).

Written by scripts/ci/classify_failures.py (ci-failure-attribution.yml); signatures are its SIGNATURES table. A machine verdict is the runner's fault, not this PR's.

[cubic-dev-ai]

1 issue found across 4 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="cmuxTests/WorkspaceUnitTests.swift">

<violation number="1" location="cmuxTests/WorkspaceUnitTests.swift:7497">
P3: This PR touches a non-UI unit test in `cmuxTests` and leaves it in `XCTestCase`, but repo policy prefers Swift Testing for touched tests even in files that already contain XCTestCase suites (file-level mixing is accepted when suites are separated). Convert the touched tests to a `@Suite`/`@Test` block, as `WorkspaceTerminalTabWorkingDirectoryTests.swift` already does in the same PR.</violation>
</file>

<sub>Reply with feedback, questions, or to request a fix.

Re-trigger cubic</sub>

[cubic-dev-ai]

P3: This PR touches a non-UI unit test in cmuxTests and leaves it in XCTestCase, but repo policy prefers Swift Testing for touched tests even in files that already contain XCTestCase suites (file-level mixing is accepted when suites are separated). Convert the touched tests to a @Suite/@Test block, as WorkspaceTerminalTabWorkingDirectoryTests.swift already does in the same PR.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At cmuxTests/WorkspaceUnitTests.swift, line 7497:

<comment>This PR touches a non-UI unit test in `cmuxTests` and leaves it in `XCTestCase`, but repo policy prefers Swift Testing for touched tests even in files that already contain XCTestCase suites (file-level mixing is accepted when suites are separated). Convert the touched tests to a `@Suite`/`@Test` block, as `WorkspaceTerminalTabWorkingDirectoryTests.swift` already does in the same PR.</comment>

<file context>
@@ -7494,12 +7494,20 @@ final class WorkspacePanelGitBranchTests: XCTestCase {
     }
 
-    func testSidebarBranchDirectoryEntriesStayStableAcrossFocusedSplitChanges() {
+    func testSidebarBranchDirectoryEntriesStayStableAcrossFocusedSplitChanges() throws {
         let workspace = Workspace()
-        let leftLiveDirectory = "/repo/left/live"
</file context>

[cursor]

Bugbot is paused — on-demand spend limit reached

Bugbot uses usage-based billing for this team and has hit its on-demand spend limit.

A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue.

[teamleaderleo]

Green at 2fdf4cc; landing. Resource check: test-only. Each test creates a few empty temp directories and removes them in defer. No product code changes, so no runtime CPU, memory or disk impact.

[github-actions]

Merge receipt for 2fdf4cc06a: every check was green at merge (14 verified; 18 skipped by policy). Full suite runs on main after merge.