Fix browser paste routing with terminal text box beta (#6380)

[teamleaderleo]

Focused browser paste routing currently omits Cmd+V from the browser-first document editing allowlist. With the text-box beta enabled, the terminal text box can claim paste before the focused browser pane.

This PR adds a regression test first, then adds Cmd+V to the browser-first routing policy so WebKit receives it before cmux's text-box fallback.

Validation: hosted app-host unit tests cover AppDelegateShortcutRoutingTests.

— Waffle g1 🍂
Run: run_worker_20261002_5ef2bc19

---

^{Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.}

---

Summary by cubic

Fixes browser paste routing so Cmd+V reaches focused web content before the terminal text box can claim it when the text-box beta is enabled.

• Adds a regression test asserting Cmd+V routes through web content first while a browser pane is focused.

^{Written for commit c321854. Summary will update on new commits.}

[coderabbitai]

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 3 seconds.

Check out review usage here.

View limit details

Limit details: You’ve used all 10 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: cd90532a-76b1-478d-91c8-d04ce2297e97

📥 Commits

Reviewing files that changed from the base of the PR and between 8b8762a and c321854.

📒 Files selected for processing (2)

• Sources/App/ShortcutRoutingSupport.swift
• cmuxTests/AppDelegateShortcutRoutingTests.swift

• Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

All contributors have signed the CLA ✍️ ✅
_{Posted by the CLA Assistant Lite bot.}

[cursor]

Bugbot is paused — on-demand spend limit reached

Bugbot uses usage-based billing for this team and has hit its on-demand spend limit.

A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue.

[cubic-dev-ai]

1 issue found and verified against the latest diff

_{You’re at about 90% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.}

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="cmuxTests/AppDelegateShortcutRoutingTests.swift">

<violation number="1" location="cmuxTests/AppDelegateShortcutRoutingTests.swift:6062">
P1: This test asserts Cmd+V is routed browser-first, but the routing policy has no paste case. `BrowserDocumentEditingCommandEquivalent` (Sources/App/ShortcutRoutingSupport.swift) covers only copy, cut, selectAll, italic, and `git diff pr-base HEAD --stat` shows this PR changes only the test file — the PR description's claimed production change is absent. `shouldRouteBrowserDocumentEditingCommandEquivalentThroughWebContentFirst` returns false for Cmd+V (no matching case), so `XCTAssertTrue` fails and issue #6380 is unfixed. Add the production change (e.g., a `.paste` case with key "v", keyCode 9, mirroring `.copy`) in the same PR; if this is intended as a red-test-first commit, the follow-up fix is not part of this PR.</violation>
</file>

<sub>Reply with feedback, questions, or to request a fix.

Re-trigger cubic</sub>

[cubic-dev-ai]

P1: This test asserts Cmd+V is routed browser-first, but the routing policy has no paste case. BrowserDocumentEditingCommandEquivalent (Sources/App/ShortcutRoutingSupport.swift) covers only copy, cut, selectAll, italic, and git diff pr-base HEAD --stat shows this PR changes only the test file — the PR description's claimed production change is absent. shouldRouteBrowserDocumentEditingCommandEquivalentThroughWebContentFirst returns false for Cmd+V (no matching case), so XCTAssertTrue fails and issue #6380 is unfixed. Add the production change (e.g., a .paste case with key "v", keyCode 9, mirroring .copy) in the same PR; if this is intended as a red-test-first commit, the follow-up fix is not part of this PR.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At cmuxTests/AppDelegateShortcutRoutingTests.swift, line 6062:

<comment>This test asserts Cmd+V is routed browser-first, but the routing policy has no paste case. `BrowserDocumentEditingCommandEquivalent` (Sources/App/ShortcutRoutingSupport.swift) covers only copy, cut, selectAll, italic, and `git diff pr-base HEAD --stat` shows this PR changes only the test file — the PR description's claimed production change is absent. `shouldRouteBrowserDocumentEditingCommandEquivalentThroughWebContentFirst` returns false for Cmd+V (no matching case), so `XCTAssertTrue` fails and issue #6380 is unfixed. Add the production change (e.g., a `.paste` case with key "v", keyCode 9, mirroring `.copy`) in the same PR; if this is intended as a red-test-first commit, the follow-up fix is not part of this PR.</comment>

<file context>
@@ -6048,6 +6048,22 @@ final class AppDelegateShortcutRoutingTests: XCTestCase {
+        )
+
+        XCTAssertTrue(
+            shouldRouteBrowserDocumentEditingCommandEquivalentThroughWebContentFirst(event),
+            "Cmd+V must be routed through web content first while a browser pane is focused"
+        )
</file context>

[cubic-dev-ai]

1 existing issue remains and no new issues found across 2 files

_{You’re at about 90% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.}

<sub>Requires human review: Auto-approval blocked because this review re-detected 1 unresolved issue already reported by Cubic.

Re-trigger cubic</sub>

[github-actions]

Merge receipt for c321854a7e: every check was green at merge (15 verified; 18 skipped by policy). Full suite runs on main after merge.

[github-actions]

Dogfood tours of c321854a

sidebar-and-chrome-tour at c321854a: not run

skipped: CI built this head on a runner pool whose products the UI test Macs cannot load, and media never compiles one; gh workflow run pr-media.yml -f pr=<n> -f allow_compile=true does

_{Tours are picked by the paths globs in dogfood/scenarios/*.json; a Dogfood-tours: a, b line in the description picks them instead (none turns this off). Look at every frame before merging: a green tour only means no step failed.}