Repository navigation
Rename edits inline or in the palette, never in an alert - #14986
Merged
Merged
Conversation
Workspace rows' "Rename Workspace…" now starts the row's inline title editor (AppKit and SwiftUI sidebars). Tab, Dock tab and group "Rename" open the palette rename editor for that exact object through a new explicit-target palette request; the palette resolves Dock tabs by their owner id. The four rename alerts, the unused promptRenameSelectedWorkspace, and their localized strings are gone. The two copies of the custom workspace color dialog are now one helper. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedNext included review available in 1 minute. View limit detailsLimit details: You’ve used all 10 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Repository: manaflow-ai/cmux/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (19)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Bugbot is paused — on-demand spend limit reachedBugbot uses usage-based billing for this team and has hit its on-demand spend limit. A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue. |
Context-menu Rename called updateSelection() before starting the inline editor. On an unselected row that switched workspaces (which can move focus to the terminal and blur, so commit, the new field) and collapsed a multi-selection. The menu path now skips selection and starts editing on the next run-loop turn, after the menu has dismissed. Double-click still selects first. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
Merge receipt for |
rustybret
pushed a commit
to rustybret/bmux
that referenced
this pull request
Sep 27, 2026
f5c179f iOS: fix the test failures that keep iOS CI red on main (manaflow-ai#14803) 8685bf5 Hold update relaunch while agents are mid-turn (manaflow-ai#14969) dc90332 Keep CLI socket-discovery tests off the host's real cmux (manaflow-ai#14919) dd3c91b docs: shorten root agent instructions and link existing procedures (manaflow-ai#14998) 8c744df Rename edits inline or in the palette, never in an alert (manaflow-ai#14986) 9ae4383 Calmer chrome motion: appear instantly, fade out only, no overshoot (manaflow-ai#14984) 6510f56 Write opencode config JSON without escaping slashes (cmux 7140) (manaflow-ai#14805) ab5e7da ci: stop catch-up merges from failing the CLA check (manaflow-ai#14913) 52c8f41 Add cmux session move for Claude sessions (manaflow-ai#14959) 36785b1 Hide decorative Settings sidebar icons from VoiceOver (manaflow-ai#14989) 4c7158c Label the sound preview button and fix mistranslated action verbs (manaflow-ai#14983) e704a77 Bound untracked paths stored in last-turn diff baselines (manaflow-ai#14980) f073df1 Fix remote Files sidebar for names that change under NFD (manaflow-ai#14978) 5c68499 Bump bonsplit: mouse wheel scrolls the overflowed tab strip (manaflow-ai#14985) 9466dcb Keep agent resume bindings through the update-relaunch save (manaflow-ai#14971) ef8b037 docs: take release notes from a Changelog section in each PR instead of CHANGELOG.md edits (manaflow-ai#14934) 6eddfd7 ci: skip the delta diff when main moved further than the pull request (manaflow-ai#14987) fefcec7 ci: attribute red PR runs to the machine or the code, re-run machine failures once (manaflow-ai#14977) c185deb Accept file drops on remote tmux mirror panes (manaflow-ai#14981) 90773c7 test: make CmuxSidebarGit probe waits event-driven (manaflow-ai#14973) 1f2dbfe ci: skip the scheduled Blacksmith cache warmers while owned pools serve PRs (manaflow-ai#14827) 2850651 docs: add a guide to customizing cmux's look (manaflow-ai#14850) b66e365 Resolve a separate sidebar's content against its own backdrop (manaflow-ai#14841) 88a9360 UI tests: one labelled frame per action, built in CI; scripts/ui-test (manaflow-ai#14966) 20cfa78 fix(omo): resolve relative file refs in the shadow config without double-loading OpenCode config (manaflow-ai#14935) f0e964c ci: make the aggregate app-host product the default, layers opt-in (manaflow-ai#14975) 52dce98 ci: run and register the machine-failure test (manaflow-ai#14972) 7bf48bc ci: route compile admission by kept-build distance across minis (manaflow-ai#14949) 44fa3f5 Offer cmux in Open With for Markdown, source, and text files (manaflow-ai#14968) 45c2d66 Replay the Claude session id of agents in cmux ssh (cmux-tui) panes (manaflow-ai#14906) b4c1b31 Label icon-only chrome buttons and localize project panel text (manaflow-ai#14926) 14a6909 seed prefetch: keep the seed adopt would pick, of any seeded width (manaflow-ai#14944) 19e73d2 ci: self-calibrating warm-distance compile estimates (manaflow-ai#14932) fa98d86 ci: redispatch focused runs the Mac failed before any test started (manaflow-ai#14963)
2 of 3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename used to have three UIs: inline editing on sidebar rows, the command palette editor, and four near-identical app-modal NSAlert dialogs (two for workspaces, two for tabs, one for groups). Now every context-menu "Rename" edits in one of the first two places.
How it works:
CommandPaletteRequestKind.renameis a new palette request whose notification carries aCommandPaletteRenameTargetinuserInfo.AppDelegate.requestCommandPaletteRename(_:preferredWindow:source:)posts it, and the palette opens its existing rename editor on that target.TabManager.dockSplitStore(ownerID:containingPanel:)). Before, it only handled a Dock browser that was focused when the palette opened, so explicit Dock targets (terminals included) now work.WorkspaceCustomColorPrompt, which also shows the Invalid Color alert.AppDelegate.promptRenameSelectedWorkspacehad no callers and is deleted.alert.renameWorkspace.*,dialog.renameWorkspace.*,alert.renameTab.*,workspaceGroup.rename.confirm,alert.cancel.Socket, CLI and AppleScript renames (
workspace.rename, tab and group rename methods) call the model setters directly and never touched these alerts, so they're unaffected.Tests:
CommandPaletteRenameTargetUserInfoTests(new) checks that each target kind round-trips through the request payload and that a request without a target is ignored.CommandPaletteRequestKindTestsnow covers the new notification name. I ran these locally withswift testinPackages/macOS/CmuxCommandPalette, along with the existing workspace rename target suite: 8 tests passed.SidebarWorkspaceRowInlineRenameTests.contextMenuRenameStartsInlineEditInsteadOfDialogopens the AppKit row's context menu, runs "Rename Workspace…", and asserts that the inline field editor takes focus with the current title and that no title gets written. This test hasn't run yet; it's for CI.scripts/verify-local.pypassed: Swift syntax, xcstrings, localization parity, project normalization, test wiring. I didn't build the app locally, so CI's build is the first native compile.Not done here: the other text-field alerts (saved layouts, fork conversation, browser prompts, Cloud machine rename) aren't rename-of-a-visible-sidebar-object flows and are unchanged. Nobody has dogfooded the SwiftUI sidebar path yet (context menu dismissal, then inline field focus). That path has no automated test: driving a SwiftUI
.contextMenufrom a unit test isn't practical here.Changelog
Changed: Rename from a context menu no longer opens a dialog: workspace rows edit their name in place, and tabs, Dock tabs and groups open the command palette's rename field.
🤖 Generated with Claude Code
Summary by cubic
Rename now edits inline on sidebar workspace rows and in the command palette for tabs, Dock tabs, and groups, replacing four near-identical rename alert dialogs. Context-menu rename on the SwiftUI sidebar no longer switches selection first, so renaming an unselected row keeps focus on the new field and preserves multi-selection.
CommandPaletteRequestKind.renamecarries the rename target in the notification payload, so one palette editor serves explicit targets.promptRenameSelectedWorkspaceare removed.Written for commit 272bdd9. Summary will update on new commits.