[WEB-2878]fix: draft creation #6230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: fixed import order in module header
WalkthroughThe pull request introduces modifications to two components: Changes
Sequence DiagramsequenceDiagram
participant User
participant IssueModal
participant Backend
User->>IssueModal: Create/Update Issue
alt Is Draft Issue
IssueModal->>Backend: Validate Draft
Backend-->>IssueModal: Draft Validation Result
IssueModal->>IssueModal: Skip Cycle/Module Assignment
else Is Non-Draft Issue
IssueModal->>Backend: Create/Update Issue
Backend-->>IssueModal: Issue Creation Result
IssueModal->>Backend: Assign to Cycle/Module
end
IssueModal->>User: Display Appropriate Notification
Possibly Related PRs
Suggested Reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
web/core/components/issues/issue-modal/base.tsx (1)
190-204: LGTM: Optimized API calls for draft issuesThe addition of the
!is_draft_issuecondition effectively prevents unnecessary API calls when creating draft issues. This optimization aligns perfectly with the PR objective.However, we could improve code clarity by extracting the cycle and module addition logic into separate methods:
-if (!is_draft_issue) { - if ( - payload.cycle_id && - payload.cycle_id !== "" && - (payload.cycle_id !== cycleId || storeType !== EIssuesStoreType.CYCLE) - ) { - await addIssueToCycle(response, payload.cycle_id); - } - if ( - payload.module_ids && - payload.module_ids.length > 0 && - (!payload.module_ids.includes(moduleId?.toString()) || storeType !== EIssuesStoreType.MODULE) - ) { - await addIssueToModule(response, payload.module_ids); - } +if (!is_draft_issue) { + await handleCycleAssignment(response, payload); + await handleModuleAssignment(response, payload); } +const handleCycleAssignment = async (issue: TIssue, payload: Partial<TIssue>) => { + if ( + payload.cycle_id && + payload.cycle_id !== "" && + (payload.cycle_id !== cycleId || storeType !== EIssuesStoreType.CYCLE) + ) { + await addIssueToCycle(issue, payload.cycle_id); + } +}; + +const handleModuleAssignment = async (issue: TIssue, payload: Partial<TIssue>) => { + if ( + payload.module_ids && + payload.module_ids.length > 0 && + (!payload.module_ids.includes(moduleId?.toString()) || storeType !== EIssuesStoreType.MODULE) + ) { + await addIssueToModule(issue, payload.module_ids); + } +};
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
web/core/components/issues/issue-modal/base.tsx(1 hunks)web/core/components/modules/module-view-header.tsx(1 hunks)
🔇 Additional comments (1)
web/core/components/modules/module-view-header.tsx (1)
13-13: LGTM: Clean utility import addition
The addition of the cn utility import from @plane/utils is clean and follows best practices.
gurusainath
approved these changes
Dec 19, 2024
This was referenced Dec 19, 2024
This was referenced Jan 2, 2025
This was referenced Jan 17, 2025
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Avoided unnecessary API calls while creating issue draft.
Type of Change
References
WEB-2878
Summary by CodeRabbit
New Features
Bug Fixes
Refactor
Style