[WEB-2859]chore: sub issue list optimization

[mathalav55]

Description

Optimized sub issue list. Avoided multiple API calls.

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• Feature (non-breaking change which adds functionality)
• Improvement (change that would cause existing functionality to not work as expected)
• Code refactoring
• Performance improvements
• Documentation update

References

WEB-2859

Summary by CodeRabbit

• Bug Fixes

  • Improved the management of sub-issue visibility within the component, ensuring consistent state updates.

• Refactor

  • Simplified the component logic by removing unnecessary asynchronous operations related to sub-issue fetching, enhancing lifecycle management.

[coderabbitai]

Walkthrough

The pull request modifies the SubIssuesCollapsibleContent component in the content.tsx file. The primary change involves simplifying the sub-issues visibility management by removing the invocation of the handleFetchSubIssues function during the cleanup phase of the useEffect hook. This adjustment streamlines the component's logic by focusing on managing visibility state directly without unnecessary complexity related to fetching sub-issues.

Changes

File	Change Summary
web/core/components/issues/issue-detail-widgets/sub-issues/content.tsx	Removed invocation of handleFetchSubIssues in cleanup of useEffect, simplifying visibility management for sub-issues.

Possibly related PRs

• [WEB-2743] chore: restrict sub-issue to have different project id than parent #5981: Changes in the CreateUpdateIssueModal component related to management of sub-issues and project IDs.
• [WEB-2817] fix: creating a new sub-issue from workspace level #6169: Modifications to the IssueDetailWidgetModals component, directly related to sub-issues creation.
• [WEB-2878]fix: draft creation #6230: Changes in the CreateUpdateIssueModalBase component, focusing on lifecycle management of issues.

Suggested labels

🌟improvement, 🧹chore

Suggested reviewers

• SatishGandham
• sriramveeraghanta
• gurusainath

Poem

🐰 Hop, hop, through the code we go,
Simplifying logic, watch it flow!
Sub-issues dance with clearer might,
No more callbacks to cause a fright.
Clean and lean, our component sings! 🌈

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between dacafa3 and 8f1a543.

📒 Files selected for processing (1)

• web/core/components/issues/issue-detail-widgets/sub-issues/content.tsx (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• web/core/components/issues/issue-detail-widgets/sub-issues/content.tsx

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (2)

web/core/components/issues/issue-detail-widgets/sub-issues/content.tsx (2)

83-87: Consider removing redundant cleanup in useEffect

The cleanup function sets the same visibility state as the setup, which appears redundant. Since you're setting the same state with the same parameters, the cleanup might not be necessary.

  useEffect(() => {
    setSubIssueHelpers(`${parentIssueId}_root`, "issue_visibility", parentIssueId);
-   return () => {
-     setSubIssueHelpers(`${parentIssueId}_root`, "issue_visibility", parentIssueId);
-   };
    // eslint-disable-next-line react-hooks/exhaustive-deps
  }, [parentIssueId]);

---

Line range hint 1-150: Implementation successfully optimizes API calls

The changes effectively achieve the PR's objective of reducing API calls by:

1. Removing the separate fetch handler
2. Simplifying visibility management
3. Using direct state updates in useEffect

The implementation maintains good React practices while improving performance.

Consider implementing a loading state or skeleton UI for better user experience during initial render.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0a320a8 and dacafa3.

📒 Files selected for processing (1)

• web/core/components/issues/issue-detail-widgets/sub-issues/content.tsx (2 hunks)