[WEB-2830]fix: create view modal - layout drop down close

[mathalav55]

Description

This update modifies the dropdown component to ensure it closes when a click is detected on the popover element.

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• Feature (non-breaking change which adds functionality)
• Improvement (change that would cause existing functionality to not work as expected)
• Code refactoring
• Performance improvements
• Documentation update

References

WEB-2830

Summary by CodeRabbit

• Bug Fixes
  • Improved event handling for the dropdown component's outside click detection, enhancing user experience when interacting with the dropdown.

[coderabbitai]

Walkthrough

The pull request introduces a modification to the useOutsideClickDetector function call in the Dropdown component within the single-select.tsx file. Specifically, a third argument true is added to the function call, which may alter the component's behavior for handling outside click events. The change appears to be subtle and does not impact the overall structure or core logic of the dropdown component.

Changes

File	Change Summary
packages/ui/src/dropdown/single-select.tsx	Modified useOutsideClickDetector function call by adding a third argument true

Possibly related PRs

• [WEB-2715] fix: draft issue type update outside click #5902: Modification of CreateUpdateIssueModalBase component, sharing similarities in user interaction and state management
• [WEB-2878]fix: draft creation #6230: Further changes to CreateUpdateIssueModalBase component, focusing on issue creation and update logic

Suggested reviewers

• SatishGandham
• rahulramesha

Poem

🐰 A dropdown's dance, a click's embrace
With one small change, a subtle grace
Three args now sing, a new refrain
Outside clicks learn a different lane
Code rabbit hops, with joy so bright! 🎉

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1059fbb and 3cb07b7.

📒 Files selected for processing (1)

• packages/ui/src/dropdown/single-select.tsx (1 hunks)

🔇 Additional comments (1)

packages/ui/src/dropdown/single-select.tsx (1)

113-113: Ensure this additional parameter doesn't cause unexpected closure behaviors.

The introduction of the third argument (true) to the useOutsideClickDetector might alter how the click events are captured and handled. Verify that the popover now closes only when intended––e.g., not when interacting with permissible elements within the dropdown.

✅ Verification successful

Let me investigate the useOutsideClickDetector hook and its usage to verify the concern about the third parameter.

---

Let me check the implementation of the useOutsideClickDetector hook to understand how the third parameter affects its behavior.

---

The third parameter is safe and follows standard event handling practices

The useCapture parameter (set to true) in useOutsideClickDetector only affects the event propagation phase and doesn't impact the core click detection logic. The hook still properly handles outside clicks by:

1. Checking if the click is outside the referenced element
2. Respecting elements with data-prevent-outside-click attribute
3. Only calling the close callback when conditions are met

🏁 Scripts executed

The following scripts were executed for the analysis:

Error: No shell scripts found

---

Script:

#!/bin/bash
# Find the implementation of useOutsideClickDetector
ast-grep --pattern 'function useOutsideClickDetector($_) {
  $$$
}'

# Also search for any other usages of this hook
rg "useOutsideClickDetector" -A 2

Length of output: 20571

---

Script:

#!/bin/bash
# Find the implementation details of useOutsideClickDetector
cat packages/hooks/src/use-outside-click-detector.tsx

Length of output: 1008

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.