[WEB-2676 ] fix: workspace draft move to project

[anmolsinghbhatia]

Changes:

This PR includes a fix for the "Move to project" action in the workspace draft. Previously, when an issue was moved from a draft to a project, any updates made by the user during the transition were not being saved. I've implemented the necessary changes to ensure that updates are now properly applied

Reference:

[WEB-2676]

Summary by CodeRabbit

• New Features

  • Improved functionality of the "Add to project" button to ensure accurate data processing when moving issues.

• Bug Fixes

  • Fixed the issue with data merging when moving an issue, enhancing the reliability of the feature.

[coderabbitai]

Walkthrough

The changes in this pull request focus on the IssueFormRoot component within web/core/components/issues/issue-modal/form.tsx. The primary modification involves the onClick handler for the "Add to project" button, which now merges the data object with the current form values retrieved from getValues(). This adjustment ensures that the latest form data is accurately processed when moving the issue, while the overall structure and logic of the component remain unchanged.

Changes

File Path	Change Summary
web/core/components/issues/issue-modal/form.tsx	Updated onClick handler in IssueFormRoot to merge data with current form values from getValues().

Possibly related PRs

• [WEB-1185] chore: minor UI improvement in issue modal. #5390: Modifies the IssueFormRoot component to integrate a new hook for project state details, related to the changes in the onClick handler.
• chore: create/ update issue modal restructure. #5385: Involves the IssueLinkCreateUpdateModal component, potentially sharing similar data handling logic with IssueFormRoot.
• [WEB-2250] fix: filter projects with create permission while selecting the project in create issue modal. #5630: Addresses project selection in the create issue modal, relevant to accurate data handling when moving issues.
• [WEB-2630] chore: double click action added to draft issue and code refactor #5821: Introduces a double-click feature for moving issues in the draft section, relating to the changes in IssueFormRoot.

Suggested reviewers

• sriramveeraghanta
• SatishGandham

🐇 In the meadow where issues play,
A button's click leads the way.
With data merged, so fresh and bright,
Moving projects feels just right!
Hops of joy, no more delay,
Let's fix those bugs, hip-hip-hooray! 🌼

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)

web/core/components/issues/issue-modal/form.tsx (1)

435-442: Approved: Ensures latest form data is included when moving issues

The changes effectively address the issue of user updates not being saved during the transition from draft to project. By merging data with getValues(), we ensure that all the latest form data is included when moving the issue.

For improved clarity and maintainability, consider extracting the merged data into a separate variable:

 onClick={() => {
   if (data?.id && data) {
+    const mergedData = {
+      ...data,
+      ...getValues(),
+    };
     moveIssue(workspaceSlug.toString(), data?.id, {
-      ...data,
-      ...getValues(),
+      ...mergedData,
     } as TWorkspaceDraftIssue);
   }
 }}

This change would make the code more readable and easier to maintain, especially if additional operations on the merged data are needed in the future.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 645a261 and 8a63fdd.

📒 Files selected for processing (1)

• web/core/components/issues/issue-modal/form.tsx (1 hunks)

🧰 Additional context used

🔇 Additional comments (1)

web/core/components/issues/issue-modal/form.tsx (1)

Line range hint 1-442: Overall impact: Focused change with minimal risk

The modification to the "Add to project" button's onClick handler is well-contained and addresses the specific issue mentioned in the PR objectives. The change is minimal, focused, and doesn't introduce any unexpected side effects to the overall component structure or logic.

This approach of making a targeted change reduces the risk of introducing new bugs while effectively solving the problem of preserving user updates during the transition from draft to project.