Merge 2025-11-12 from base repo by luca-domenichini · Pull Request #2 · luca-domenichini/wpfui

luca-domenichini · 2025-11-12T14:55:25Z

Merge from base repo.

…storing Maximized State via Code lepoco#1453 (lepoco#1466) * Fix: Title Bar MaxButton Fix: Title Bar MaxButton When Maximizing Window Programmatically * Update: Improved Client Area Border Handling on Programmatic Maximize Update: Improved Client Area Border Handling on Programmatic Maximize

* Fix lepoco#1551 * Remove Transparent background from Grid

Co-authored-by: pomian <13592821+pomianowski@users.noreply.github.com>

…epoco#1553)

…s not visible. (lepoco#1556)

…lepoco#1558)

…at XAML (lepoco#1559)

* tests: Update tests * fix: Rollback XAML styling

* Fix PasswordBox not pasting correctly * Refactor GetNewPassword to use TextChange collection --------- Co-authored-by: pomian <13592821+pomianowski@users.noreply.github.com>

…#1543) Co-authored-by: pomian <13592821+pomianowski@users.noreply.github.com>

…o#1541) Updated the `Border` elements for the "Top" and "Footer" sections in `NavigationViewCompact.xaml` to include a `BorderThickness` property with a value of `.5`. This ensures a uniform appearance for the separators across the UI. Fixes issue lepoco#1514 Co-authored-by: pomian <13592821+pomianowski@users.noreply.github.com>

…verlapped by buttons in MessageBox

* fix: Fix system tray right-click menu not displaying * fix: Fix system tray right-click menu not displaying * Update src/Wpf.Ui.Tray/Controls/NotifyIcon.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update src/Wpf.Ui.Tray/Controls/NotifyIcon.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update src/Wpf.Ui.Tray/Controls/NotifyIcon.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update src/Wpf.Ui.Tray/Controls/NotifyIcon.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * feat: add tray menu demo * Comment out Menu DataContext update in NotifyIcon Commented out the line that updates Menu's DataContext to prevent potential issues. * Change trayMenuItems type from object to Control --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: pomian <13592821+pomianowski@users.noreply.github.com>

…oco#1560) * fix: restore window resize capability in title bar area - Split `TitleBar` class into partial classes, add `TitleBar.WindowResize.cs` file to separate window resize logic, maintaining code modularity and single responsibility. - Add `WM_DPICHANGED` message enum value in `User32.cs` and fix `GetWindowRect` method parameter types. * refactor(User32): use WinDef.RECT in User32.GetWindowRect Follow the existing convention of using the WinDef.RECT alias. * chore: Format code --------- Co-authored-by: pomian <13592821+pomianowski@users.noreply.github.com>

…epoco#1532) * Update NavigationViewConstants.xaml * Update NavigationViewCompact.xaml

…ce (lepoco#1533) * Update UiElementExtensions.cs * Update UiElementExtensions.cs --------- Co-authored-by: pomian <13592821+pomianowski@users.noreply.github.com>

…oco#1529) * Update NavigationLeftFluent.xaml * Update NavigationViewBasePaneButtonStyle.xaml * Update NavigationViewBottom.xaml * Update NavigationViewCompact.xaml * Update NavigationViewLeftMinimalCompact.xaml * Update NavigationViewTop.xaml

… account (lepoco#1525)

…epoco#1523) * Update DropDownButton.cs * Update DropDownButton.cs

* Fix RadioButton issues * Update Light.xaml * Update Dark.xaml * Update RadioButton.xaml --------- Co-authored-by: pomian <13592821+pomianowski@users.noreply.github.com>

Co-authored-by: pomian <13592821+pomianowski@users.noreply.github.com>

…poco#1472) * Add files via upload * Update ContextMenu.xaml * Update MenuItem.xaml * Update ToolTip.xaml * Update EffectThicknessDecorator.cs Add Animation stuff. * Update ComboBox.xaml

* Update DatePicker.xaml * Update Calendar.xaml * Update DatePicker.xaml * Create DatePickerButtonPaddingConverter.cs * Create NegativeThicknessConverter.cs * Update DatePicker.xaml * Delete src/Wpf.Ui/Converters/NegativeThicknessConverter.cs * Do the same styling here as TextBox Reference: https://github.com/lepoco/wpfui/pull/1520/files

…e properties to `NavigationView` component (lepoco#1464) * Add IsTopAndFooterSeparatorVisible property to NavigationView component * Split IsTopAndFooterSeparatorVisible into IsTopSeparatorVisible and IsFooterSeparatorVisible --------- Co-authored-by: pomian <13592821+pomianowski@users.noreply.github.com>

* Fix various fill colors * Update Dark.xaml * Update Dark.xaml

* Update PasswordBox.cs * Center buttons/icons to follow TextBox style * Update PasswordBox.xaml * Update PasswordBox.xaml * Update PasswordBox.xaml * Unify remainder

…t code (lepoco#1564) * chore: Prepare tools * chore: Format code * fix: Disable border when inactive in Win11

…log (lepoco#1565)

…NavigationView (lepoco#1567)

… User32 (lepoco#1566)

* Remove unused pinvoke. * Initial changes to CsWin32. * Move all of UxTheme to CsWin32. * Formatting... * Initial User32 bits. * Convert User32 to CsWin32. * Remove a bit more. * Initial DwmApi changes. * Finalize DwnApi Interop. * Shell to CsWin32. * Another from User32. * Fix titlebar coloring. * Replace the rest with CsWin32. * This is no longer used now. * Formatting. --------- Co-authored-by: Nuklon <23340481+Nuklon@users.noreply.github.com>

…lepoco#1574)

Co-authored-by: Nuklon <23340481+Nuklon@users.noreply.github.com>

* feat: Bump .NET 10 * chore: Bump drawing common * chore: Do not fail on error * ci: Update pipelines * fix: Ignore MC3080 * drop internal for .NET 10

Copilot

Pull Request Overview

This PR merges updates from the base repository dated 2025-11-12. The changes include upgrading the target framework from .NET 9.0 to .NET 10.0, introducing a new integration testing infrastructure using FlaUI and xUnit v3, migrating from manual P/Invoke declarations to Microsoft.Windows.CsWin32, and various UI control improvements and theme refinements.

Framework upgrade to .NET 10.0-windows
New integration test project with FlaUI for UI automation testing
Migration to CsWin32 for Windows API interop, removing manual P/Invoke code
UI control enhancements (ToggleSwitch, RadioButton, PasswordBox, SplitButton, etc.)
Theme color updates and new pressed state brushes
TitleBar window resize support improvements

Reviewed Changes

Copilot reviewed 176 out of 176 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
tests/Wpf.Ui.UnitTests/Wpf.Ui.UnitTests.csproj	Upgraded target framework to net10.0-windows
tests/Wpf.Ui.Gallery.UnitTests/Wpf.Ui.Gallery.UnitTests.csproj	Removed entire project file
tests/Wpf.Ui.Gallery.IntegrationTests/*	Added new integration test project with xUnit v3 and FlaUI
src/Wpf.Ui/Wpf.Ui.csproj	Updated target frameworks, added CsWin32 package, removed PolySharp and StyleCop
src/Wpf.Ui/Interop/*	Migrated to CsWin32, removed manual P/Invoke declarations
src/Wpf.Ui/Controls/*	Various UI improvements and bug fixes across multiple controls
src/Wpf.Ui/Resources/Theme/*	Updated theme colors and added new pressed state brushes

Copilot · 2025-11-12T14:59:21Z

src/Wpf.Ui/Extensions/PInvokeExtensions.cs

+    extension(DWMWINDOWATTRIBUTE attr)
+    {
+        /// <summary>
+        /// Gets the undocumented window attribute for enabling Mica effect on a window.
+        /// </summary>
+        public static DWMWINDOWATTRIBUTE DWMWA_MICA_EFFECT => (DWMWINDOWATTRIBUTE)1029;
+
+        /// <summary>
+        /// Gets the window attribute used to enable immersive dark mode prior to Windows 11.
+        /// </summary>
+        public static DWMWINDOWATTRIBUTE DMWA_USE_IMMERSIVE_DARK_MODE_OLD =>
+            DWMWINDOWATTRIBUTE.DWMWA_USE_IMMERSIVE_DARK_MODE - 1;
+    }


The 'extension' keyword syntax is not standard C#. This appears to be an attempt to use C# 13's extension types feature, but the syntax is incorrect. Extensions should be declared using proper extension type syntax or as static extension methods. This code will likely not compile.

Copilot · 2025-11-12T14:59:22Z

src/Wpf.Ui/Controls/TitleBar/TitleBar.cs

+		if (message == PInvoke.WM_NCHITTEST)
+		{
+			if (TrailingContent is UIElement || Header is UIElement || CenterContent is UIElement)
+			{
+				UIElement? headerLeftUIElement = Header as UIElement;


Inconsistent indentation detected. Lines 705-716 use tabs while the rest of the file uses spaces. This creates inconsistent formatting and should be corrected to match the project's indentation style.

Nuklon and others added 30 commits October 25, 2025 20:30

fix: NullReferenceException in SplitButton

c9e1dc0

fix: Scrollbar alignment (lepoco#1462)

45cf326

fix: Check DwmIsCompositionEnabled result (lepoco#1548)

d1ba15c

fix: CardExpander is difficult to expand (lepoco#1552)

3d577e9

* Fix lepoco#1551 * Remove Transparent background from Grid

fix: Navigation buttons jumping. (lepoco#1542)

636666d

Co-authored-by: pomian <13592821+pomianowski@users.noreply.github.com>

fix: make UiApplication instance thread-static instead of static (l…

aac47a4

…epoco#1553)

fix(ListView): use themed brush for disabled background (lepoco#1554)

a6dad2e

fix: AutoSuggestBox should not occupy space if it does not exist or i…

19b0fe5

…s not visible. (lepoco#1556)

fix: UpdateAutoSuggestBoxSuggestions When MenuItems_CollectionChanged (…

d92eed3

…lepoco#1558)

test: Create new integraiton tests with FlaUI UIA3 and XUnit v3; form…

376cf30

…at XAML (lepoco#1559)

fix: Rollback XAML styling (lepoco#1563)

ae3e1ee

* tests: Update tests * fix: Rollback XAML styling

fix: PasswordBox issues with pasting/copying (lepoco#1547)

30aa7f8

* Fix PasswordBox not pasting correctly * Refactor GetNewPassword to use TextChange collection --------- Co-authored-by: pomian <13592821+pomianowski@users.noreply.github.com>

fix: make notifyicon contextmenu display (lepoco#1534)

0fa7746

fix: Prevent unexpected ContentDialog behavior at design time (lepoco…

266d68e

…#1543) Co-authored-by: pomian <13592821+pomianowski@users.noreply.github.com>

fix(controls): Wrapped header and increased right margin to prevent o…

90a43af

…verlapped by buttons in MessageBox

feat(controls): Allow changing NavigationViewItem border thickness (l…

7e8c07b

…epoco#1532) * Update NavigationViewConstants.xaml * Update NavigationViewCompact.xaml

fix(controls): Check if UIElement is connected to presentation sour…

1a94dbf

…ce (lepoco#1533) * Update UiElementExtensions.cs * Update UiElementExtensions.cs --------- Co-authored-by: pomian <13592821+pomianowski@users.noreply.github.com>

fix(controls): NavigationView top separator (lepoco#1530)

d439c96

fix(controls): ToolTip taking parent line height and font weight into…

b8ee7d4

… account (lepoco#1525)

fix(controls): DropDownButton not working inside ToolBar overflow (l…

1377404

…epoco#1523) * Update DropDownButton.cs * Update DropDownButton.cs

fix(controls): RadioButton style (lepoco#1522)

2ea97a7

* Fix RadioButton issues * Update Light.xaml * Update Dark.xaml * Update RadioButton.xaml --------- Co-authored-by: pomian <13592821+pomianowski@users.noreply.github.com>

fix(controls): ToggleSwitch ignoring Padding (lepoco#1521)

0932954

Update NavigationViewBasePaneButtonStyle.xaml (lepoco#1524)

9db01ba

Co-authored-by: pomian <13592821+pomianowski@users.noreply.github.com>

fix(controls): Tooltips, context menu, and comboboxes drop shadow (le…

3139927

…poco#1472) * Add files via upload * Update ContextMenu.xaml * Update MenuItem.xaml * Update ToolTip.xaml * Update EffectThicknessDecorator.cs Add Animation stuff. * Update ComboBox.xaml

evandrofadul and others added 13 commits November 7, 2025 15:02

fix(controls): Fix various fill colors (lepoco#1507)

2313df9

* Fix various fill colors * Update Dark.xaml * Update Dark.xaml

fix(controls): Fix PasswordBox various issues (lepoco#1501)

20cb0dd

* Update PasswordBox.cs * Center buttons/icons to follow TextBox style * Update PasswordBox.xaml * Update PasswordBox.xaml * Update PasswordBox.xaml * Unify remainder

fix: Remove border when inactive, update docs, instructions and forma…

54048f1

…t code (lepoco#1564) * chore: Prepare tools * chore: Format code * fix: Disable border when inactive in Win11

fix(controls): Prevent keyboard focus on hidden buttons in ContentDia…

fbd92cc

…log (lepoco#1565)

fix(controls): Fix TopSeparator and FooterSeparator rendering in Left…

43862ee

…NavigationView (lepoco#1567)

fix(interop): Correct LPRECT parameter type for AdjustWindowRectEx in…

1f20c0e

… User32 (lepoco#1566)

fix(controls): Prevent keyboard focus on hidden buttons in MessageBox (…

a7f58f5

…lepoco#1574)

fix(controls): Remove MinWidth of TabItem (lepoco#1568)

5c70262

Fix Calendar styling. (lepoco#1570)

9ad1d69

Co-authored-by: Nuklon <23340481+Nuklon@users.noreply.github.com>

feat: Update to .NET 10, bump version to 4.1.0 (lepoco#1575)

d686224

* feat: Bump .NET 10 * chore: Bump drawing common * chore: Do not fail on error * ci: Update pipelines * fix: Ignore MC3080 * drop internal for .NET 10

Merge from main

ca36d66

Copilot AI review requested due to automatic review settings November 12, 2025 14:55

github-actions bot added documentation Improvements or additions to documentation release PR github_actions dotnet styles themes titlebar tray controls navigation gallery labels Nov 12, 2025

luca-domenichini merged commit 6366d69 into main Nov 12, 2025
6 checks passed

Copilot started reviewing on behalf of luca-domenichini November 12, 2025 14:55 View session

Copilot finished reviewing on behalf of luca-domenichini November 12, 2025 14:56

Copilot AI reviewed Nov 12, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Merge 2025-11-12 from base repo#2

Merge 2025-11-12 from base repo#2
luca-domenichini merged 64 commits intomainfrom
merge-2025-11-12

luca-domenichini commented Nov 12, 2025

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Nov 12, 2025

Uh oh!

Copilot AI Nov 12, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

17 participants

Conversation

luca-domenichini commented Nov 12, 2025

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Nov 12, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 12, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

17 participants