Skip to content

fix: Prevent unexpected ContentDialog behavior at design time. #1543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pomianowski merged 2 commits into from
Nov 7, 2025
Merged

fix: Prevent unexpected ContentDialog behavior at design time. #1543

pomianowski merged 2 commits into from
Nov 7, 2025

Conversation

@apachezy
Copy link
Contributor

@apachezy apachezy commented Oct 9, 2025

Pull request type

Please check the type of change your PR introduces:

  • Update
  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes

What is the current behavior?

  • ContentDialog invokes runtime code during design time, causing unexpected behavior in the designer, such as:
The designer fails to display content

What is the new behavior?

  • After the fix, the issue is resolved. The designer now properly displays content.

@apachezy apachezy requested a review from pomianowski as a code owner October 9, 2025 16:50
@github-actions github-actions bot added controls Changes to the appearance or logic of custom controls. PR Pull request dotnet release labels Oct 9, 2025
@pomianowski pomianowski changed the title Prevent unexpected ContentDialog behavior at design time. fix: Prevent unexpected ContentDialog behavior at design time. Nov 7, 2025
@pomianowski pomianowski merged commit 266d68e into lepoco:main Nov 7, 2025
2 checks passed
@apachezy apachezy deleted the fix/ContentDialog-design-time branch November 8, 2025 13:01
This was referenced Nov 24, 2025
Merged
Closed
Merged
This was referenced Dec 2, 2025
Closed
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pomianowski pomianowski pomianowski approved these changes

Assignees

No one assigned

Labels

controls Changes to the appearance or logic of custom controls. dotnet PR Pull request release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@apachezy @pomianowski