fix(controls): Tooltips, context menu, and comboboxes drop shadow#1472
fix(controls): Tooltips, context menu, and comboboxes drop shadow#1472pomianowski merged 6 commits intolepoco:mainfrom
Conversation
|
@pomianowski best viewed without whitespace changes: |
|
Have you considered adding this change to ComboBoxes as well? I believe all you need is the following: EDIT: Seems like wrapping the ComboBox popup in EffectThicknessDecorator breaks its animation a bit for some reason.. Might need some additional changes so feel free to ignore me 😓 |
Yes, with animations there are some issues due to added margins, and the translation gets rendered above the combobox. There are some possibilities:
I'll commit some changes for this. |
Add Animation stuff.
|
|
||
| namespace Wpf.Ui.Controls; | ||
|
|
||
| public class EffectThicknessDecorator : Decorator |
There was a problem hiding this comment.
Consider giving this class a doc block (explaining the purpose) that effectively repeats this part from the PR:
This is because effects get clipped. [..] The solution is to add a decorator that wraps around it.


Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Currently, the drop shadow used by tooltips and context menus are broken. This is because effects get clipped.

What is the new behavior?
The solution is to add a decorator that wraps around it. I also updated the dropshadows to follow original colors (they were far too dark). The tooltips have less shadow than context menus in WinUI.