fix(LeftNavigationViewTemplate): release layout space when AutoSuggestBox is null or invisible #1556
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
controls
pomianowski
approved these changes
Oct 29, 2025
apachezy
added a commit
to apachezy/wpfui
that referenced
this pull request
Oct 31, 2025
…ist or is not visible. (lepoco#1556)" This reverts commit 19b0fe5.
apachezy
added a commit
to apachezy/wpfui
that referenced
this pull request
Nov 1, 2025
…xist or is not visible. (lepoco#1556)" This reverts commit ca1b7ca.
This was referenced Nov 24, 2025
This was referenced Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
When the
AutoSuggestBoxproperty isnullor itsVisibilityis set toCollapsed, the related UI elements (AutoSuggestBoxContentPresenterandPART_ToggleButton) still occupy layout space, resulting in unnecessary blank areas and visual misalignment.When
Visibilityis set toCollapsed:default.mp4
What is the new behavior?
Enhanced the template triggers to ensure that when
AutoSuggestBoxis invisible or non-existent, the related containers completely release their layout space. Adjacent elements above and below can now connect seamlessly, restoring proper layout alignment.default.mp4