fix(controls): Fix PasswordBox various issues#1501
Merged
pomianowski merged 7 commits intolepoco:mainfrom Nov 7, 2025
Merged
Conversation
github-actions
bot
added
controls
Nuklon
commented
Aug 5, 2025
| protected override void OnTextChanged(TextChangedEventArgs e) | ||
| { | ||
| UpdateTextContents(isTriggeredByTextInput: true); | ||
| SetPlaceholderTextVisibility(); |
Collaborator
Author
There was a problem hiding this comment.
This should always be called to ensure the placeholder/clear button is in sync with the text.
Nuklon
changed the title
Collaborator
Author
|
2nd commit centers the buttons vertically, same as TextBox, so they look largely identical again. |
Nuklon
commented
Aug 5, 2025
Comment on lines
-34
to
-36
| <Thickness x:Key="PasswordBoxLeftIconMargin">10,8,0,0</Thickness> | ||
| <Thickness x:Key="PasswordBoxRightIconMargin">0,8,10,0</Thickness> | ||
| <Thickness x:Key="PasswordBoxButtonMargin">0,5,4,0</Thickness> |
Collaborator
Author
There was a problem hiding this comment.
Identical to TextBox now (copied from there).
pomianowski
approved these changes
Nov 7, 2025
pomianowski
changed the title
PasswordBox various issues
Collaborator
Author
|
Conflicts resolved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
If you use a PasswordBox, and specify a default password (Password="Test" for example), or bind it to an existing password, the placeholder doesn't get removed and the clear button isn't updated.
What is the new behavior?
As one would expect.