Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sync to latest master #18

Merged
merged 42 commits into from
Apr 9, 2019
Merged

sync to latest master #18

merged 42 commits into from
Apr 9, 2019

Conversation

lihaofd
Copy link
Owner

@lihaofd lihaofd commented Apr 9, 2019

Description

(Brief description on what this PR is about)

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

ZhennanQin and others added 30 commits March 26, 2019 15:32
@ZhennanQin @pengzhao-intel
Enhance PartitionGraph (#14277)
f8a0dbc 
* Enhance PartitionGraph

* Fix lint

* Fix test

* Run CI

* Change subgraph property register

* Change doc

* Fix name

* Run CI

* Add env var in doc

* Address comments.

* run CI
@lanking520
[MXNET-1285] Draw bounding box with Scala/Java Image API (#14474)
092af36 
* new feature to draw bounding box

* add Java support

* add point wise verification

* cancel the check on top-left corner

* add this example to Java world and fixing bugs
@stu1130 @anirudh2290
reenable the test (#14483)
651a6c0
@vandanavk @wkcn
Fix script retrieval (#14519)
c4cd49c 
* Correct script wget. Without this change, wget was retrieving html.

* Dont use CI scripts
@ThomasDelteil
add filter to warnings (#14532)
3d20f2a
@perdasilva @lanking520
Adds context parameter to check_rnn_layer_forward calls in test_lstmp (…
67c10f9 
…#14529)
@ciyongch @pengzhao-intel
Performance improving for MKL-DNN Quantized FullyConnected (#14528)
5d2a451 
* Cached bias to Quantized FullyCOnnected based on Subgraph to improve performance

* retrigger CI

* retrigger CI
@haojin2 @eric-haibin-lin
speedup SequenceMask on GPU (#14445)
09daf22
@yuxihu @anirudh2290
Tidy up storage allocation and deallocation (#14480)
645c778 
* free memory when dptr is not nullptr

* skip memory allocation when handle size is 0

* update comments

* update Alloc in naive storage manager

* address comments

* add unit test for size 0 allocation
@andrewfayres @nswamy
Memory fixes. Resolves #10867, and resolves #14080 (#14372)
102b46f 
* Fixes for memory leak when reshaping executor

* Fixed Adam Optimizer memory leak

* Cleanup for PR

* Added unit test for new ResourceScope method

* Removing import that was added by overzealous ide

* Add back in an import

* Added flags for executor to know whether or not it owns NDArrays for disposal

* Moving to ResourceScope.using implementation

* Changes to make ResourceScope.using work with existing scope

* Updating ResourceScope to work with existing scopes via usingIfScopeExists method

* Fix clojure unit tests

* Fixes to be compatibile with how clojure is using ResourceScope

* Removing some unnecessary changes

* Adding scope assertion in unit test
@terrytangyuan @wkcn
Remove unnecessary "also" in README.md (#14543)
84c2ae1 
* Remove unnecessary "also" in README.md

* retrigger CI
@tolitius @gigasquid
[clojure]: add comp-metric based on CompositeEvalMetric (#14553)
b20f08b 
* [clojure]: add comp-metric based on CompositeEvalMetric

* [clojure]: add comp-metric test
@Chouffe @gigasquid
Chouffe/clojure fix tests (#14531)
9f5dfbf 
* fix ndarray-test namespace

* fix symbol-test

* fix operator_test

* fix imageclassifier_test

* fix rest of test files and add fixme pragmas

* fix util-test

* [clojure][tests] remove keyword->snake-case duplicate
@Chouffe @gigasquid
[clojure][image] add draw-bounding-box interop (#14533)
4d04238 
* [clojure][image] add draw-bounding-box interop

* [clojure][image] add more specs and type conversion
@gigasquid
fix tests (#14565)
5f19362
@ZhennanQin @pengzhao-intel
Enhance subgraph API (#14113)
8c2a25f 
* Enhance subgraph API

* Fix lint

* Trigger CI

* Fix test

* split into another PR

* Rename partition_graph to build_graph

* Fix lint

* Fix merge

* run CI

* run CI

* fix quantize script

* fix ssd script

* Address reminisce comment
@ptrendx @wkcn
Do not touch GPU 0 during ReleaseAll (#14550)
4075212 
* Do not touch GPU 0 during ReleaseAll

* Fixing lint and fixes from review

* Fix

* Fixes from review
@frankfliu @wkcn
Change CUB submodule to track Nvidia CUB project. (#13322)
b6eac1d 
* Change CUB submodule to track Nvidia CUB project.

Directly change submodule URL will impact every developer.
"git submodule update" won't work, developer has to use
"git submodule sync" first.

* retrigger CI
@perdasilva @wkcn
Fixes static build script for cub directory rename (#14578)
09ba8be
@sunrongda @zhreshold
example/ssd/evaluate/eval_metric.py (#14561)
33b6543 
* eval_metric.py

* Update eval_metric.py

* Update eval_metric.py
@wkcn @zhreshold
Support SyncBatchNorm5D (#14542)
e2f5b47 
* support SyncBatchNorm5D

* fix

* update testcase and reformat code

* retrigger CI

* update test case

* test

* Retrigger CI

* disable cudnn for batchnorm

* fix BatchNorm(cudnn)

* fix build

* Remove a testcase

* Update sync_batch_norm-inl.h

* update unittest

* update unittest

* update test

* fix test

* change atol and rtol

* BN(cudnn) 5d

* update test

* test

* Testing

* Update batch_norm.cu

* test cudnnoff

* Update test_operator.py

* update BN! : )
@Chancebair @marcoabreu
Disable Flaky Test test_poisson_generator (#14540)
6392666
@leleamol @anirudh2290
[MXNET-1357] Fix the cpp-examples to add exception handling (#14441)
9e4ee99 
* Adding exception handling to the cpp-package examples.

* Updating exception handling to catch dmlc::error.

* Removed the catch all exception.
@perdasilva @wkcn
Updates gpu tests to use CUDNN_VERSION supplied by the environment bu…
dde77d4 
…t default to 7.0.3 if not set (#14595)
@nihui @wkcn
fix build cpp examples option (#14562)
214ce63
@stu1130 @szha
Fix flaky test poisson generator & test_negative_binomial_generator (#…
a6fd0e9 
…14571)

* set success_rate to 0.2

* fix the flaky test

* reenable the test
@zjost @szha
Fixing unintentional variable overloading (#14438)
6478691 
* Fixing unintentional variable overloading

* Adding to conbributor list

* Fixing unintentional variable overloading

* Adding to conbributor list

* Fixing unintentional variable overloading

* Adding to conbributor list

* Fixing unintentional variable overloading

* Adding to conbributor list
@lanking520
[MXNET-1379] update reshape operator (#14600)
b482a44 
* update reshape operator

* Satisfy the Lint God =v=

* update the jni header signature
@lebeg @aaronmarkham
Updated documentation about nightly tests (#14493)
28fe552 
* Updated documentation about nightly tests

* Update tests/nightly/README.md

Co-Authored-By: lebeg <[email protected]>

* Update tests/nightly/README.md

Co-Authored-By: lebeg <[email protected]>

* Update tests/nightly/README.md

Co-Authored-By: lebeg <[email protected]>
@yuxihu @eric-haibin-lin
set _scale in Trainer using optimizer rescale_grad (#14593)
53743d6
stu1130 and others added 12 commits April 3, 2019 16:15
@stu1130 @sandeep-krishnamurthy
Add Gluon Transformer Crop (#14259)
5241c1b 
* implement crop

* add crop operator

* fix for linter

* add. backword and refactor the code

* fix error namespace

* fix the website build failure

* start adding the unit test of backword

* add unit test for backward

* address the comment

* add missing statement

* fix the website error

* fix the website building

* add missing doc
@xinyu-intel @pengzhao-intel
fix quantize graph pass (#14605)
7983ef1
@haojin2
GELU (#14449)
b3ab101
@samskalicky @lanking520
added note about cuda9.2 requirement (#14140)
43f7c12
@lanking520
Add BERT QA Scala/Java example (#14592)
d5d1d7a 
* add BertQA major code piece

* add scripts and bug fixes

* add integration test

* address comments

* address doc comments
@larroy @apeforest
Fix dockerized GPU builds in dev_menu (#14603)
b68f18c
@higumachan @azai91
replace std::random_shuffle to std::shuffle (#14523)
dab4ffc
@anirudh2290 @wkcn
Add exception handling support for waitall (#14397)
3781816 
* Relax constexpr restriction

* Change imagenet_gen_qsym_mkldnn

* Add exception handling support for waitall

* Fix exception handling documentation

* Revert constexpr change

* Add comments

* Fix test

* Skip exception for op check names

* Print exceptions thrown for CPP Package NDArray module

* Reducing batch_size to make cpp-package example pass

* Fix bug: #14426

* use ExceptionRef in threaded_engine code

* add note for performance impact of waitall

* Add check for GPU contxt

* Use range for with const reference

* Improve comments and error message for exception handling test

* Change exception_ptr name in waitall

* Fix bug
@mightydeveloper @wkcn
split_and_load can now handle num_ctx > num_data. Issue #13909 (#14607)
daabe5c
@Chancebair @lanking520
Comment out test_unix_python3_tensorrt_gpu step (#14642)
1dafa1a
@vdantu @ThomasDelteil
The folder python-howto was removed in an earlier commit. The referen…
9dda62f 
…ce to that folder was not removed. Making a PR to remove the reference to this folder to keep documents consistent (#14573)
@abhinavs95 @zhreshold
Fix aspect ratio sampling for RandomResizedCrop (#14585)
4530ad8 
* added log sampling for aspect ratio

* added test

* added comments

* fix test

* remove math, fix test
@lihaofd lihaofd merged commit 61b7c06 into lihaofd:statefulrnn Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.