This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
[GPU] Fix test_gluon_gpu:test_lstmp #14529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm |
|
It would be great if you could mention |
|
@mxnet-label-bot update [CI, Test] |
|
@lanking520 thank you! |
vdantu
pushed a commit
to vdantu/incubator-mxnet
that referenced
this pull request
Mar 31, 2019
ZhennanQin
pushed a commit
to ZhennanQin/incubator-mxnet
that referenced
this pull request
Apr 3, 2019
nswamy
pushed a commit
that referenced
this pull request
Apr 5, 2019
haohuanw
pushed a commit
to haohuanw/incubator-mxnet
that referenced
this pull request
Jun 23, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The way CI is at the moment, some failing GPU tests are going undetected. I'm putting together a PR (#14513) to update CI do CUDA v10 and fix a bug in the way the cuDNN version gets used in the tests.
In this PR, I fix one such failing test introduced in PR #14219, where the function signature for
check_rnn_layer_forwardwas changed and a context parameter added with a default value of mx.cpu().The test_lstmp test fails because it uses the
check_rnn_layer_forwardfunction without setting the context to mx.gpu(0).In this PR, I remove the default value to force the user to set the context. Thus avoiding such errors in the future.
For an example failure, see: http://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/mxnet-validation%2Funix-gpu/detail/PR-14513/5/pipeline