Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Reenable the test_kvstore_gpu.test_rsp_push_pull #14483

Merged
merged 1 commit into from
Mar 27, 2019

Conversation

stu1130
Copy link
Contributor

@stu1130 stu1130 commented Mar 21, 2019

Description

Fixes #14189
Ran 10k with latest MXNet code.

TOTAL                                              18749  13965   6519     94    20%
[success] 100.00% test_kvstore_gpu.test_rsp_push_pull: 22578.5869s
----------------------------------------------------------------------
Ran 1 test in 22578.592s

OK

also test with seed 89411477 (module seed 1829754103), seed 1155716252 (module seed 1032824746), all passed

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

Comments

Copy link
Member

@yuxihu yuxihu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Member

@wkcn wkcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@pinaraws
Copy link

@mxnet-label-bot add[pr-awaiting-merge]

@marcoabreu marcoabreu added the pr-awaiting-merge Review and CI is complete. Ready to Merge label Mar 25, 2019
@pinaraws
Copy link

@mxnet-label-bot add[Test]

Copy link
Contributor

@larroy larroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Did you try to reproduce with ci/build.py as per CI environment?

@stu1130
Copy link
Contributor Author

stu1130 commented Mar 27, 2019

yes I used ci/build.py instead of building from source

@anirudh2290 anirudh2290 merged commit 651a6c0 into apache:master Mar 27, 2019
vdantu pushed a commit to vdantu/incubator-mxnet that referenced this pull request Mar 31, 2019
ZhennanQin pushed a commit to ZhennanQin/incubator-mxnet that referenced this pull request Apr 3, 2019
nswamy pushed a commit that referenced this pull request Apr 5, 2019
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-merge Review and CI is complete. Ready to Merge Test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Flaky Test] Python3: MKLDNN-GPU test_kvstore_gpu.test_rsp_push_pull
8 participants