Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[Quantization] Fix quantize graph pass #14605

Merged
merged 1 commit into from
Apr 4, 2019

Conversation

xinyu-intel
Copy link
Contributor

Description

This PR fix a bug in quantize graph pass. When quantizing the last layer of a whole model, a dequantize layer will be insert after this layer with wrong input index:

          "arg_nodes": [0, 1, 2],
          "node_row_ptr": [0, 1, 2, 3, 4, 5],
          "heads": [[4, 0, 0]]
        }
      ]
    },
    {
      "op": "_contrib_dequantize",
      "name": "sg_mkldnn_conv_relu_19_dequantize",
      "inputs": [[67, 0, 0], [67, 3, 0], [67, 4, 0]]
    }
  ],
  "arg_nodes": [
    0,
    3,

So, this PR changes to use output_num to calculate the index of min/max and below is the correct quantized graph:

          "arg_nodes": [0, 1, 2],
          "node_row_ptr": [0, 1, 2, 3, 4, 5],
          "heads": [[4, 0, 0]]
        }
      ]
    },
    {
      "op": "_contrib_dequantize",
      "name": "sg_mkldnn_conv_relu_19_dequantize",
      "inputs": [[67, 0, 0], [67, 1, 0], [67, 2, 0]]
    }
  ],
  "arg_nodes": [
    0,
    3,

@pengzhao-intel @ciyongch @ZhennanQin @reminisce

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@pengzhao-intel pengzhao-intel changed the title Fix quantize graph pass [MKLDNN] Fix quantize graph pass Apr 3, 2019
@pengzhao-intel pengzhao-intel changed the title [MKLDNN] Fix quantize graph pass [Quantization] Fix quantize graph pass Apr 3, 2019
@piyushghai
Copy link
Contributor

@xinyu-intel Thanks for your contributions.

@mxnet-label-bot Add [Quantization]

@marcoabreu marcoabreu added the Quantization Issues/Feature Requests related to Quantization label Apr 3, 2019
Copy link
Contributor

@pengzhao-intel pengzhao-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZhennanQin
Copy link
Contributor

LGTM. Thanks for fixing this.

Copy link
Contributor

@ciyongch ciyongch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@pengzhao-intel
Copy link
Contributor

Thanks for your contribution. Merging now.

@pengzhao-intel pengzhao-intel merged commit 7983ef1 into apache:master Apr 4, 2019
nswamy pushed a commit that referenced this pull request Apr 5, 2019
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Quantization Issues/Feature Requests related to Quantization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants