This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Nightly test fix: add filter to warnings #14532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mxnet-label-bot update [Test, pr-awaiting-merge] |
|
I run it on my EC2 instance and all failed tutorials are working now. |
Ishitori
approved these changes
Mar 26, 2019
vdantu
pushed a commit
to vdantu/incubator-mxnet
that referenced
this pull request
Mar 31, 2019
ZhennanQin
pushed a commit
to ZhennanQin/incubator-mxnet
that referenced
this pull request
Apr 3, 2019
nswamy
pushed a commit
that referenced
this pull request
Apr 5, 2019
5 tasks
haohuanw
pushed a commit
to haohuanw/incubator-mxnet
that referenced
this pull request
Jun 23, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
nightly test fails because of warnings that have been introduced. However there are no ways to not get the warnings at the moment. Adding filters to ignore them.
That's a bad solution, but I think it's worst to simply ignore warnings in the nightly tests. We need to either remove the warnings that have been introduced in : #14214, suppress the warnings in the imports / onnx load API or update the API to specify the type at model loading time.