Revert recent changes resulting in problems with mix-manifest.json
#68
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is only triage to get Laravel Mix working again. Additional work may be required to get Livewire's
manifest.json
working correctly.This reverts #67 f2e34ab which was an attempt to fix #35 758214a.
The end result of #67 was mix-manifest.json being included in the asset artifact and being removed from the code deployment artifact. This meant Laravel Mix applications would fail as they expect to be able to read the contents of
public/mix-manifest.json
at runtime.This does not attempt to fix the original issue #35 was trying to address. #35 would have included
public/manifest.json
in the code deployment artifact (the desired behavior) but #67 would ensure bothpublic/manifest.json
andpublic/mix-manifest.json
would end up in the asset artifact.Unclear if Livewire's
manifest.json
is needed by both client (so needs to be a part of the asset artifact) and code (so also needs to be in the code deployment artifact) so not trying to make that decision now.See this comment on #67 regarding my proposal for solving this problem in a more generic way by allowing people to specify which public assets should be included only in the code deployment artifact or also in the code deployment artifact.
TL;DR: For example, allowing
vapor.yml
to support specifying paths and patterns like this: