Keep json asset files in deployment artifact #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simensen
added a commit
to simensen/vapor-cli
that referenced
this pull request
Sep 12, 2020
This is only triage to get Laravel Mix working again. Additional work may be required to get Livewire's `manifest.json` working correctly. This reverts laravel#67 f2e34ab which was an attempt to fix laravel#35 758214a. The end result of laravel#67 was mix-manifest.json being included in the asset artifact and being removed from the code deployment artifact. This meant Laravel Mix applications would fail as they expect to be able to read the contents of `public/mix-manifest.json` at runtime. This does not attempt to fix the original issue laravel#35 was trying to address. laravel#35 would have included `public/manifest.json` in the code deployment artifact (the desired behavior) but laravel#67 would ensure both `public/manifest.json` and `public/mix-manifest.json` would end up in the asset artifact. Unclear if `manifest.json` is needed by both client (so needs to be a part of the asset artifact) and code (so also needs to be in the code deployment artifact) so not trying to make that decision now.
This was referenced Sep 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Livewire looks for a
manifest.jsonfile to check if its JS assets are published and current (reference). I've loosened the strictness of which files should be kept in the/publicpath to include all*.jsonfiles rather than justmix-manifest.json.Json files are typically only a few bytes in size, however, you'd prefer it to be a bit more specific, I can update to include only
*manifest.jsonfiles.If this solution is not ideal or too specific, would a
include:key in the manifest be considered?