Ensure manifest.json stays in the code deployment artifact for Laravel Livewire #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This would also make life a lot easier for people working with PWAs |
|
The This PR will fix Livewire on Vapor. Thanks @simensen! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request aims to support Laravel Liveware separate from Laravel Mix.
It is not clear to me if this is correct, though. Does Laravel Livewire need to access
public/manifest.jsonfrom the client, or only from the code? If it needs to be accessed from both, I don't know if it is possible to easily supportpublic/manifest.jsonin both the asset artifact and the code deployment artifact at this time.See #68, #67, #35 for reference.