Combine all manifest.json asset names #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed
*manifest.jsonasset names as a single definition.Relevant PRs: #68 (comment) #70
I was under the impression that Vapor would include all non-asset files in the artifact that is uploaded to the lambdas. Looks like they are all removed, unless specified here. For the Tailwind CSS Laravel and Importmap Laravel to work well with Vapor, I had to rename their manifests to start with a dot, so
public/.tailwindcss-manifest.jsonandpublic/.importmap-manifest.json, since dotfiles are kept by default (although users might disable it in the Vapor manifest).I think adding anything that ends with
manifest.jsonwould solve all existing cases (Mix and Livewire), as well as the new cases (Tailwind CSS Laravel and Importmap Laravel).Unless you folks know a better place for me to generate these manifest files. In the case of Tailwind CSS Laravel and Importmap Laravel, these files are only used internally by the package, not something that needs to be served from the browser, for instance. I'm placing them in the public folder because that seems to be the norm, anything inside the
storagefolder also seems to be removed (right?).