Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert recent changes resulting in problems with mix-manifest.json #68

Merged
merged 1 commit into from
Sep 12, 2020

Commits on Sep 12, 2020

  1. Revert recent changes resulting in problems with mix-manifest.json

    This is only triage to get Laravel Mix working again. Additional work
    may be required to get Livewire's `manifest.json` working correctly.
    
    This reverts laravel#67 f2e34ab which was an
    attempt to fix laravel#35 758214a.
    
    The end result of laravel#67 was mix-manifest.json being included in the asset
    artifact and being removed from the code deployment artifact. This meant
    Laravel Mix applications would fail as they expect to be able to read
    the contents of `public/mix-manifest.json` at runtime.
    
    This does not attempt to fix the original issue laravel#35 was trying to
    address. laravel#35 would have included `public/manifest.json` in the code
    deployment artifact (the desired behavior) but laravel#67 would ensure both
    `public/manifest.json` and `public/mix-manifest.json` would end up in
    the asset artifact.
    
    Unclear if `manifest.json` is needed by both client (so needs to be a
    part of the asset artifact) and code (so also needs to be in the code
    deployment artifact) so not trying to make that decision now.
    simensen committed Sep 12, 2020
    Configuration menu
    Copy the full SHA
    22f30bd View commit details
    Browse the repository at this point in the history