Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate all KEPs to the new template #2220

Closed
wojtek-t opened this issue Dec 29, 2020 · 11 comments · Fixed by #2536
Closed

Migrate all KEPs to the new template #2220

wojtek-t opened this issue Dec 29, 2020 · 11 comments · Fixed by #2536
Assignees
Labels
sig/architecture Categorizes an issue or PR as relevant to SIG Architecture.

Comments

@wojtek-t
Copy link
Member

wojtek-t commented Dec 29, 2020

This will facilitate strenghtening KEP validation

@wojtek-t wojtek-t self-assigned this Dec 29, 2020
@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Dec 29, 2020
@wojtek-t
Copy link
Member Author

/sig architecture

@k8s-ci-robot k8s-ci-robot added sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 29, 2020
paulcastro added a commit to paulcastro/enhancements that referenced this issue Jan 12, 2021
paulcastro added a commit to paulcastro/enhancements that referenced this issue Jan 12, 2021
paulcastro added a commit to paulcastro/enhancements that referenced this issue Jan 12, 2021
paulcastro added a commit to paulcastro/enhancements that referenced this issue Jan 12, 2021
paulcastro added a commit to paulcastro/enhancements that referenced this issue Jan 12, 2021
paulcastro added a commit to paulcastro/enhancements that referenced this issue Jan 12, 2021
paulcastro added a commit to paulcastro/enhancements that referenced this issue Jan 12, 2021
@wojtek-t
Copy link
Member Author

The missing remaining itmes:

sig-apimachinery:

  • /20200309-consistent-resource-versions-semantics [requires creating an issue]

sig-cloud-provider:

  • 3 cloud-provider KEPS (alibaba, baiducloud, huaweicloud)

sig-cluster-lifecycle:

  • a bunch of stuff

sig-instrumentation:

  • /1209-metrics-stability - [requires a bit of cleanup]

sig-network:

@shekhar-rajak
Copy link
Contributor

  • I need clarification for "sig-cluster-lifecycle". I see directories and sub-directories. Should we just remove the sub-directories under the "sig-cluster-lifecycle" and follow the same pattern as others ?

  • Same for sig-instrumentation /1209-metrics-stability directory

@wojtek-t
Copy link
Member Author

I need clarification for "sig-cluster-lifecycle". I see directories and sub-directories. Should we just remove the sub-directories under the "sig-cluster-lifecycle" and follow the same pattern as others ?

No - this splits it to kind of "subprojects". We should basically put the new templates there, e.g. there will be
/sig-cluster-lifecycle/kubeadm/12345-kep-title/(first kep)
/sig-cluster-lifecycle/kubeadm/23466-kep-title/(second kep)

Same for sig-instrumentation /1209-metrics-stability directory

Let's leave it for now - I will handle it later.

@k8s-ci-robot
Copy link
Contributor

@wojtek-t: The label(s) sig/kep), sig/kep) cannot be applied, because the repository doesn't have them

In response to this:

I need clarification for "sig-cluster-lifecycle". I see directories and sub-directories. Should we just remove the sub-directories under the "sig-cluster-lifecycle" and follow the same pattern as others ?

No - this splits it to kind of "subprojects". We should basically put the new templates there, e.g. there will be
/sig-cluster-lifecycle/kubeadm/12345-kep-title/(first kep)
/sig-cluster-lifecycle/kubeadm/23466-kep-title/(second kep)

Same for sig-instrumentation /1209-metrics-stability directory

Let's leave it for now - I will handle it later.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wojtek-t
Copy link
Member Author

@shekhar-rajak - if would be able to help with cluster-lifecycle, cloud-provider and api-machinery remaining ones it would be huge help - I will handle the remaining networking and instrumentaiton one.

@shekhar-rajak
Copy link
Contributor

Sure @wojtek-t , I will work on it.

@neolit123
Copy link
Member

one problem here is that all tracking issues get detached from the KEP locations. i can try updating the SIG CL tracking issues next week.

another problem is that KEP cross-ref links get broken.
i don't think we have many of these in SIG CL, but other SIGs might have them.

@wojtek-t
Copy link
Member Author

another problem is that KEP cross-ref links get broken.
i don't think we have many of these in SIG CL, but other SIGs might have them.

If needed, we can add symlinks to the new locations (there are a few for other SIGs).

@wojtek-t
Copy link
Member Author

There are just few more:

time="2021-02-17T21:12:02+01:00" level=error msg="FAIL: /20200309-consistent-resource-versions-semantics/kep.yaml"
time="2021-02-17T21:12:02+01:00" level=error msg="FAIL: /providers/0020-cloud-provider-alibaba-cloud.md"
time="2021-02-17T21:12:02+01:00" level=error msg="FAIL: /providers/0022-cloud-provider-baiducloud.md"
time="2021-02-17T21:12:02+01:00" level=error msg="FAIL: /providers/20191206-cloud-provider-huaweicloud.md"
time="2021-02-17T21:12:02+01:00" level=error msg="FAIL: /1209-metrics-stability/20190404-kubernetes-control-plane-metrics-stability.md"
time="2021-02-17T21:12:02+01:00" level=error msg="FAIL: /1209-metrics-stability/20190605-metrics-stability-migration.md"
time="2021-02-17T21:12:02+01:00" level=error msg="FAIL: /1209-metrics-stability/20190605-metrics-validation-and-verification.md"
time="2021-02-17T21:12:02+01:00" level=error msg="FAIL: /1209-metrics-stability/20191028-metrics-stability-to-beta.md"

@wojtek-t
Copy link
Member Author

Once #2524 and #2533 are merged, all KEPs will be migrated to the new template.
The only remaining thing I would like to do then is to strenghten validation a bit more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/architecture Categorizes an issue or PR as relevant to SIG Architecture.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants