Skip to content

Migrate some networking KEPs to new template #2190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 16, 2020
Merged

Migrate some networking KEPs to new template #2190

merged 1 commit into from
Dec 16, 2020

Conversation

wojtek-t
Copy link
Member

Not status changes or other changes - just migrating existing info to new templates.

This will be useful to strengthen validation of kep.yaml eventually.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory labels Dec 16, 2020
@k8s-ci-robot k8s-ci-robot requested review from dcbw and thockin December 16, 2020 14:23
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. sig/network Categorizes an issue or PR as relevant to SIG Network. labels Dec 16, 2020
@wojtek-t wojtek-t force-pushed the migrate_keps_to_new_template_1 branch from 5726be4 to db60127 Compare December 16, 2020 14:25
thockin
thockin reviewed Dec 16, 2020
View reviewed changes
Copy link
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! This has been on my TODO list for a long time :)

Thanks!

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: thockin, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 16, 2020
@k8s-ci-robot k8s-ci-robot merged commit c8b1d10 into kubernetes:master Dec 16, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Dec 16, 2020
@wojtek-t
Copy link
Member Author

@thockin - didn't migrate everything, just some;
there are few more network for which I didn't immediately find corresponding issue - so there is still work to do :)

@wojtek-t
Copy link
Member Author

ref #2220

@wojtek-t wojtek-t deleted the migrate_keps_to_new_template_1 branch December 29, 2020 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thockin thockin thockin left review comments

@dcbw dcbw Awaiting requested review from dcbw

Assignees

@thockin thockin

@johnbelamaric johnbelamaric

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/network Categorizes an issue or PR as relevant to SIG Network. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.
4 participants
@wojtek-t @k8s-ci-robot @thockin @johnbelamaric