Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate remaining cloud-provider KEPs to new template #2533

Merged
merged 1 commit into from
Feb 22, 2021
Merged

Migrate remaining cloud-provider KEPs to new template #2533

merged 1 commit into from
Feb 22, 2021

Conversation

wojtek-t
Copy link
Member

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. labels Feb 21, 2021
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 21, 2021
@wojtek-t wojtek-t mentioned this pull request Feb 21, 2021
Closed
justaugustus
justaugustus requested changes Feb 22, 2021
View reviewed changes
Copy link
Member

@justaugustus justaugustus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wojtek-t -- Just a few nits on empty fields.

Do we also want to add some symlinks to prevent external 404s?

keps/sig-cloud-provider/providers/2532-huawei-cloud/kep.yaml Outdated
Comment on lines 16 to 18
see-also:
replaces:
superseded-by:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
see-also:
replaces:
superseded-by:

We can drop the empty fields.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

keps/sig-cloud-provider/providers/2532-huawei-cloud/kep.yaml Outdated
approvers:
- "@andrewsykim"
- "@cheftako"
editor: TBD
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
editor: TBD

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

keps/sig-cloud-provider/providers/2531-baidu-cloud/kep.yaml Outdated
- "@cheftako"
- "@hogepodge"
- "@jagosan"
editor: TBD
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
editor: TBD

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

wojtek-t
wojtek-t commented Feb 22, 2021
View reviewed changes
Copy link
Member Author

@wojtek-t wojtek-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@justaugustus - Re symlinks - I don't see them being referenced anywhere (other than the issues, which I will update once this PR merges). So I don't think it's really needed.

keps/sig-cloud-provider/providers/2531-baidu-cloud/kep.yaml Outdated
- "@cheftako"
- "@hogepodge"
- "@jagosan"
editor: TBD
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

keps/sig-cloud-provider/providers/2532-huawei-cloud/kep.yaml Outdated
approvers:
- "@andrewsykim"
- "@cheftako"
editor: TBD
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

keps/sig-cloud-provider/providers/2532-huawei-cloud/kep.yaml Outdated
Comment on lines 16 to 18
see-also:
replaces:
superseded-by:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@justaugustus
Copy link
Member

@justaugustus - Re symlinks - I don't see them being referenced anywhere (other than the issues, which I will update once this PR merges). So I don't think it's really needed.

SGTM!
/lgtm
/approve
/hold for SIG Cloud Provider

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 22, 2021
@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 22, 2021
@andrewsykim
Copy link
Member

/approve

Thanks @wojtek-t

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewsykim, justaugustus, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wojtek-t
Copy link
Member Author

/hold cancel

[based on Andrew`s approve above]

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 22, 2021
@k8s-ci-robot k8s-ci-robot merged commit 846705f into kubernetes:master Feb 22, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justaugustus justaugustus justaugustus requested changes

@andrewsykim andrewsykim Awaiting requested review from andrewsykim

@cheftako cheftako Awaiting requested review from cheftako

Assignees

@justaugustus justaugustus

@cheftako cheftako

@johnbelamaric johnbelamaric

@andrewsykim andrewsykim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.
6 participants
@wojtek-t @justaugustus @andrewsykim @k8s-ci-robot @cheftako @johnbelamaric