Skip to content

Migrating from old kep to new template: sig-network #2446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 12, 2021
Merged

Migrating from old kep to new template: sig-network #2446

merged 1 commit into from
Feb 12, 2021
+92 −100

Conversation

ghost
Copy link

@ghost ghost commented Feb 7, 2021

Related to: #2220

Migrating the old KEP files into new format - sig-network

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory labels Feb 7, 2021
@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 7, 2021
This was referenced Feb 7, 2021
Closed
Closed
Closed
Closed
Closed
@ghost ghost force-pushed the kep_new_template_sig_network branch from 060d82f to 29b1bbe Compare February 7, 2021 13:35
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 7, 2021
@ghost
Copy link
Author

ghost commented Feb 7, 2021

This PR is ready for review.

wojtek-t
wojtek-t reviewed Feb 7, 2021
View reviewed changes
keps/sig-network/2445-NodeLocal-DNS-cache/kep.yaml Outdated
@@ -0,0 +1,19 @@
title: NodeLocal DNS Cache
kep-number: 2445
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is tricky, because technically we already have this:
https://github.com/kubernetes/enhancements/tree/master/keps/sig-network/1024-nodelocal-cache-dns

I guess this one should probably be somehow merged with that one KEP.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, those 2 should merge, we don't need a whole new KEP

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shekhar-rajak - So let's maybe leave this out of the PR and merge those in a separate PR.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wojtek-t @thockin for the review. Now "NodeLocal DNS Cache" key is not migrated to new template. I have updated the PR

@wojtek-t
Copy link
Member

wojtek-t commented Feb 7, 2021

/assign @thockin

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 8, 2021
thockin
thockin reviewed Feb 8, 2021
View reviewed changes
Copy link
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are all implemented already (sigh)

@ghost ghost force-pushed the kep_new_template_sig_network branch 2 times, most recently from 1cd8950 to c5e8cbf Compare February 9, 2021 07:42
@ghost
Copy link
Author

ghost commented Feb 9, 2021

This PR is ready for review.

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 9, 2021
@thockin
Copy link
Member

thockin commented Feb 9, 2021

Other than node-local., LGTM

@ghost ghost force-pushed the kep_new_template_sig_network branch from c5e8cbf to 64f0cd8 Compare February 10, 2021 14:42
@ghost
Copy link
Author

ghost commented Feb 10, 2021

This PR is ready now. Please have a look.

@wojtek-t
Copy link
Member

/lgtm

we need to wait for Tim`s approval

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 10, 2021
@wojtek-t wojtek-t mentioned this pull request Feb 11, 2021
Closed
thockin
thockin reviewed Feb 11, 2021
View reviewed changes
Copy link
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: shekhar-rajak, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 11, 2021
wojtek-t
wojtek-t reviewed Feb 12, 2021
View reviewed changes
keps/sig-network/2449-move-externalDNS-out-of-kubernetes-incubator/kep.yaml
kep-number: 2449
authors:
- "@njuettner"
owning-sig: sig-network
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shekhar-rajak - this failed validation because of lack of "status: implemented"

please fix

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for review I will do this

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@Shekharrajak
Migrating from old kep to new template: sig-network keps
13a4bd1 
Migrating from old kep to new template: sig-network - updated the status

Migrating from old kep to new template: sig-network - NodeLocal DNS Cache is not migrated

added missing field in kep.yaml for 2449
@ghost ghost force-pushed the kep_new_template_sig_network branch from 64f0cd8 to 13a4bd1 Compare February 12, 2021 07:40
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 12, 2021
@wojtek-t
Copy link
Member

/lgtm

thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 12, 2021
@k8s-ci-robot k8s-ci-robot merged commit 5385cde into kubernetes:master Feb 12, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caseydavenport caseydavenport Awaiting requested review from caseydavenport

@dcbw dcbw Awaiting requested review from dcbw

Assignees

@thockin thockin

@wojtek-t wojtek-t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/network Categorizes an issue or PR as relevant to SIG Network. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.
4 participants
@wojtek-t @thockin @k8s-ci-robot @Shekharrajak