Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate remaining auth keps to new template #2208

Merged
merged 1 commit into from
Dec 22, 2020
Merged

Migrate remaining auth keps to new template #2208

merged 1 commit into from
Dec 22, 2020

Conversation

wojtek-t
Copy link
Member

Not status changes or other changes - just migrating existing info to new templates.

This will be useful to strengthen validation of kep.yaml eventually.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/auth Categorizes an issue or PR as relevant to SIG Auth. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 22, 2020
@liggitt
Copy link
Member

liggitt commented Dec 22, 2020

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 22, 2020
@k8s-ci-robot k8s-ci-robot merged commit 273591a into kubernetes:master Dec 22, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Dec 22, 2020
@wojtek-t
Copy link
Member Author

ref #2220

@wojtek-t wojtek-t deleted the migrate_keps_to_new_template_8 branch December 29, 2020 18:48
@enj enj mentioned this pull request Nov 9, 2022
Merged
enj
enj reviewed Nov 9, 2022
View reviewed changes
keps/sig-auth/740-service-account-external-signing/kep.yaml
editor: '@micahhausler'
creation-date: 2019-01-16
last-updated: 2019-05-17
status: implementable
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is incorrect as #1564 never made it. I have opened #3653 to fix this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this just copied the existing implementable status from https://github.com/kubernetes/enhancements/pull/2208/files#diff-d3f596ee0bc64d6a9a5d8083691e407607119b7b60b2feecee69d9251114adf4L18

it sounds like it was maybe unintentional, but it like the KEP had implementable status on initial merge - https://github.com/kubernetes/enhancements/pull/704/files#diff-b8d51ea5e342526a09d4c7a6e6323a77c3a9d05ddca0c1dd0d52dc9f87aa4291R18

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, let me fix up my description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enj enj enj left review comments

@liggitt liggitt Awaiting requested review from liggitt

@mikedanese mikedanese Awaiting requested review from mikedanese

@deads2k deads2k Awaiting requested review from deads2k

@tallclair tallclair Awaiting requested review from tallclair

Assignees

@liggitt liggitt

@johnbelamaric johnbelamaric

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/auth Categorizes an issue or PR as relevant to SIG Auth. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.
5 participants
@wojtek-t @liggitt @k8s-ci-robot @enj @johnbelamaric