docs(aws): tutorial with kind and localstack#6048
docs(aws): tutorial with kind and localstack#6048k8s-ci-robot merged 13 commits intokubernetes-sigs:masterfrom
Conversation
k8s-ci-robot
added
docs
cncf-cla: yes
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
ivankatliarchuk
force-pushed
the
docs-add-tutorial-aws-localstack
branch
from
b1c9c3c to
d000d41
Compare
Pull Request Test Coverage Report for Build 23479221178Details
💛 - Coveralls |
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
|
Removed dependency bump |
* master: somehow single test was not fixed (kubernetes-sigs#6059) refactore(registry): move registry selector to registry package (kubernetes-sigs#6047) fix(domain-exclusion): domain exclusion filter fix (kubernetes-sigs#6050) chore(wrapper): centralized endpoint validation (kubernetes-sigs#6041) test(coverage): improve code coverage for different files (kubernetes-sigs#6045) chore(lint): configure modernize linter (kubernetes-sigs#6035) docs(proposal): Gateway API annotation placement clarity proposal (kubernetes-sigs#5919) fix(scripts): helm plugins install disable verify (kubernetes-sigs#6057) feat(cli): remove cobra cli support (kubernetes-sigs#6034) fix(chart): ptsc indentation (kubernetes-sigs#6054) chore(deps): bump renovatebot/github-action (kubernetes-sigs#6051) feat(aws): enable support for NAPTR records (kubernetes-sigs#6022) refactor: extract normalizeDNSName to idna package for reuse (kubernetes-sigs#6043)
mkdocs.yml
Outdated
| j2_comment_start_string: '[[#' | ||
| j2_comment_end_string: '#]]' | ||
| - tags: | ||
| tags_file: tags.md |
There was a problem hiding this comment.
There is no tags.md in the tree. 🤔 Isn't this missing from this PR?
Anyway, it would probably be better to introduce a tag system in external docs in a dedicated PR, and not this PR.
There was a problem hiding this comment.
I'll create a separate PR. You are right.
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
| It also creates TXT records for ownership tracking. When the Service is deleted, ExternalDNS automatically cleans up the DNS records. | ||
|
|
||
| ```mermaid | ||
| sequenceDiagram |
There was a problem hiding this comment.
Non-blocking comment, just a thought: to me, in this diagram, User & Kubectl looks quite similar. Wdyt about simplifying the diagram and remove one of them ?
| The ownership mechanism ensures ExternalDNS only modifies records it created. | ||
|
|
||
| ```mermaid | ||
| flowchart TD |
There was a problem hiding this comment.
In this diagram, the green and the pink are not readable:
You'll need to either change the background color or the text color.
There was a problem hiding this comment.
Strange. This is how it lookg on github
I've changed color-scheme a bit
Co-authored-by: Michel Loiseleur <97035654+mloiseleur@users.noreply.github.com>
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
|
Thanks 👍 . 
|
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
|
Made the text black as well |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mloiseleur The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
4 participants
What does it do ?
Similar tutorial to #5926
External DNS + AWS localstack. Tested step by step, all works on Mac
How to run mkdocs https://github.com/kubernetes-sigs/external-dns/blob/master/docs/contributing/dev-guide.md#contribute-to-documentation
follow-up:
Motivation
Knowledge share
More