fix(lint): single file was not modernized#6059
Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:masterfrom Dec 28, 2025
Merged
fix(lint): single file was not modernized#6059k8s-ci-robot merged 1 commit intokubernetes-sigs:masterfrom
k8s-ci-robot merged 1 commit intokubernetes-sigs:masterfrom
Conversation
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
k8s-ci-robot
added
source
size/S
ivankatliarchuk
changed the title
Pull Request Test Coverage Report for Build 20551411454Details
💛 - Coveralls |
Contributor
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Member
Author
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ivankatliarchuk The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
ivankatliarchuk
added a commit
to gofogo/k8s-sigs-external-dns-fork
that referenced
this pull request
Dec 28, 2025
* master: somehow single test was not fixed (kubernetes-sigs#6059)
ivankatliarchuk
added a commit
to gofogo/k8s-sigs-external-dns-fork
that referenced
this pull request
Dec 28, 2025
* master: somehow single test was not fixed (kubernetes-sigs#6059) refactore(registry): move registry selector to registry package (kubernetes-sigs#6047) fix(domain-exclusion): domain exclusion filter fix (kubernetes-sigs#6050) chore(wrapper): centralized endpoint validation (kubernetes-sigs#6041) test(coverage): improve code coverage for different files (kubernetes-sigs#6045) chore(lint): configure modernize linter (kubernetes-sigs#6035) docs(proposal): Gateway API annotation placement clarity proposal (kubernetes-sigs#5919) fix(scripts): helm plugins install disable verify (kubernetes-sigs#6057) feat(cli): remove cobra cli support (kubernetes-sigs#6034) fix(chart): ptsc indentation (kubernetes-sigs#6054) chore(deps): bump renovatebot/github-action (kubernetes-sigs#6051) feat(aws): enable support for NAPTR records (kubernetes-sigs#6022) refactor: extract normalizeDNSName to idna package for reuse (kubernetes-sigs#6043)
ivankatliarchuk
added a commit
to gofogo/k8s-sigs-external-dns-fork
that referenced
this pull request
Dec 28, 2025
* master: somehow single test was not fixed (kubernetes-sigs#6059)
ivankatliarchuk
added a commit
to gofogo/k8s-sigs-external-dns-fork
that referenced
this pull request
Dec 29, 2025
* master: somehow single test was not fixed (kubernetes-sigs#6059)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does it do ?
Bad timing.
Modernize added here: #6035
Failing(not modern) test added here: #6045
More