fix(domain-exclusion): domain exclusion filter fix#6050
Merged
k8s-ci-robot merged 3 commits intokubernetes-sigs:masterfrom Dec 27, 2025
Merged
fix(domain-exclusion): domain exclusion filter fix#6050k8s-ci-robot merged 3 commits intokubernetes-sigs:masterfrom
k8s-ci-robot merged 3 commits intokubernetes-sigs:masterfrom
Conversation
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
k8s-ci-robot
added
controller
Pull Request Test Coverage Report for Build 20430783058Details
💛 - Coveralls |
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
Collaborator
|
@tatyana12345 @asahnovskiy-deloitte @gzenrique Do you think you can test this PR and confirm if it fixes your issue? See how to test a PR if needed. |
k8s-ci-robot
added
the
lgtm
Member
Author
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ivankatliarchuk The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
3 tasks
ivankatliarchuk
added a commit
to gofogo/k8s-sigs-external-dns-fork
that referenced
this pull request
Dec 28, 2025
* master: somehow single test was not fixed (kubernetes-sigs#6059) refactore(registry): move registry selector to registry package (kubernetes-sigs#6047) fix(domain-exclusion): domain exclusion filter fix (kubernetes-sigs#6050) chore(wrapper): centralized endpoint validation (kubernetes-sigs#6041) test(coverage): improve code coverage for different files (kubernetes-sigs#6045) chore(lint): configure modernize linter (kubernetes-sigs#6035) docs(proposal): Gateway API annotation placement clarity proposal (kubernetes-sigs#5919) fix(scripts): helm plugins install disable verify (kubernetes-sigs#6057) feat(cli): remove cobra cli support (kubernetes-sigs#6034) fix(chart): ptsc indentation (kubernetes-sigs#6054) chore(deps): bump renovatebot/github-action (kubernetes-sigs#6051) feat(aws): enable support for NAPTR records (kubernetes-sigs#6022) refactor: extract normalizeDNSName to idna package for reuse (kubernetes-sigs#6043)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does it do ?
Finally found a problem.
--regex-domain-exclusionis silently ignored unless--regex-domain-filteris set, causing confusion and unexpected DNS records being managed.The
endpoint/domain_filter.go#matchRegexfunction had a bug where it would accept domains that didn't match the inclusion filter, as long as they also didn't match the exclusion filter.Changes made:
follow-up PR #6055
Motivation
Fixes #5674
Fixes #2255
More