fix(chart): ptsc indentation#6054
Conversation
|
Welcome @andylim0221! |
|
Hi @andylim0221. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
2b2cf50 to
47d1186
Compare
|
Could you write a helm unittests pls https://github.com/kubernetes-sigs/external-dns/tree/master/charts/external-dns/tests? |
|
/ok-to-test |
|
@ivankatliarchuk I added helm unittest and it's passed. Please help to verify. |
|
/lgtm |
Pull Request Test Coverage Report for Build 20475790444Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
|
@andylim0221 could you also add a note in This patch is needed to fix the CI in #6005. |
|
The CHANGELOG is updated. |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ivankatliarchuk The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* master: somehow single test was not fixed (kubernetes-sigs#6059) refactore(registry): move registry selector to registry package (kubernetes-sigs#6047) fix(domain-exclusion): domain exclusion filter fix (kubernetes-sigs#6050) chore(wrapper): centralized endpoint validation (kubernetes-sigs#6041) test(coverage): improve code coverage for different files (kubernetes-sigs#6045) chore(lint): configure modernize linter (kubernetes-sigs#6035) docs(proposal): Gateway API annotation placement clarity proposal (kubernetes-sigs#5919) fix(scripts): helm plugins install disable verify (kubernetes-sigs#6057) feat(cli): remove cobra cli support (kubernetes-sigs#6034) fix(chart): ptsc indentation (kubernetes-sigs#6054) chore(deps): bump renovatebot/github-action (kubernetes-sigs#6051) feat(aws): enable support for NAPTR records (kubernetes-sigs#6022) refactor: extract normalizeDNSName to idna package for reuse (kubernetes-sigs#6043)
What does it do ?
before updating indentation,
topologySpreadConstraintslooks like this:this PR is to fix the indentation so that it looks like this:
Motivation
To help in release v1.20.0 helm chart.
More