Skip to content

fix(chart): ptsc indentation#6054

Merged
k8s-ci-robot merged 5 commits intokubernetes-sigs:masterfrom
andylim0221:fix/helm-chart-indentation
Dec 26, 2025
Merged

fix(chart): ptsc indentation#6054
k8s-ci-robot merged 5 commits intokubernetes-sigs:masterfrom
andylim0221:fix/helm-chart-indentation

Conversation

@andylim0221
Copy link
Copy Markdown
Contributor

@andylim0221 andylim0221 commented Dec 23, 2025

What does it do ?

before updating indentation, topologySpreadConstraints looks like this:

# helm template external-dns charts/external-dns --values charts/external-dns/ci/ci-values.yaml --namespace default --show-only templates/deployment.yaml

...
      topologySpreadConstraints:
        - maxSkew: 1
          topologyKey: topology.kubernetes.io/zone
          whenUnsatisfiable: ScheduleAnyway
          labelSelector:
            matchLabels:
            app.kubernetes.io/name: external-dns
            app.kubernetes.io/instance: external-dns

this PR is to fix the indentation so that it looks like this:

...
      topologySpreadConstraints:
        - maxSkew: 1
          topologyKey: topology.kubernetes.io/zone
          whenUnsatisfiable: ScheduleAnyway
          labelSelector:
            matchLabels:
              app.kubernetes.io/name: external-dns
              app.kubernetes.io/instance: external-dns

Motivation

To help in release v1.20.0 helm chart.

More

  • Yes, this PR title follows Conventional Commits
  • Yes, I added unit tests
  • Yes, I updated end user documentation accordingly

@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla bot commented Dec 23, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Welcome @andylim0221!

It looks like this is your first PR to kubernetes-sigs/external-dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/external-dns has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @andylim0221. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Dec 23, 2025
@andylim0221 andylim0221 force-pushed the fix/helm-chart-indentation branch from 2b2cf50 to 47d1186 Compare December 23, 2025 05:31
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Dec 23, 2025
@ivankatliarchuk
Copy link
Copy Markdown
Member

Could you write a helm unittests pls https://github.com/kubernetes-sigs/external-dns/tree/master/charts/external-dns/tests?

@ivankatliarchuk
Copy link
Copy Markdown
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 23, 2025
@k8s-ci-robot k8s-ci-robot added github_actions Pull requests that update GitHub Actions code size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 23, 2025
@andylim0221
Copy link
Copy Markdown
Contributor Author

andylim0221 commented Dec 23, 2025

@ivankatliarchuk I added helm unittest and it's passed. Please help to verify.

@ivankatliarchuk
Copy link
Copy Markdown
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 23, 2025
@coveralls
Copy link
Copy Markdown

coveralls commented Dec 23, 2025

Pull Request Test Coverage Report for Build 20475790444

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.005%) to 78.692%

Files with Coverage Reduction New Missed Lines %
openshift_route.go 1 79.49%
Totals Coverage Status
Change from base Build 20412655513: -0.005%
Covered Lines: 16021
Relevant Lines: 20359

💛 - Coveralls

@vflaux
Copy link
Copy Markdown
Contributor

vflaux commented Dec 23, 2025

@andylim0221 could you also add a note in charts/external-dns/CHANGELOG.md?

This patch is needed to fix the CI in #6005.

@vflaux vflaux mentioned this pull request Dec 23, 2025
3 tasks
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 24, 2025
@andylim0221
Copy link
Copy Markdown
Contributor Author

@vflaux

The CHANGELOG is updated.

@vflaux
Copy link
Copy Markdown
Contributor

vflaux commented Dec 24, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 24, 2025
@mloiseleur mloiseleur changed the title fix(chart): fixed Helm chart PTSC indentation fix(chart): ptsc indentation Dec 24, 2025
@ivankatliarchuk
Copy link
Copy Markdown
Member

/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ivankatliarchuk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 26, 2025
@k8s-ci-robot k8s-ci-robot merged commit 81cf4da into kubernetes-sigs:master Dec 26, 2025
19 checks passed
ivankatliarchuk added a commit to gofogo/k8s-sigs-external-dns-fork that referenced this pull request Dec 28, 2025
* master:
  somehow single test was not fixed (kubernetes-sigs#6059)
  refactore(registry): move registry selector to registry package (kubernetes-sigs#6047)
  fix(domain-exclusion): domain exclusion filter fix (kubernetes-sigs#6050)
  chore(wrapper): centralized endpoint validation (kubernetes-sigs#6041)
  test(coverage): improve code coverage for different files (kubernetes-sigs#6045)
  chore(lint): configure modernize linter (kubernetes-sigs#6035)
  docs(proposal): Gateway API annotation placement clarity proposal (kubernetes-sigs#5919)
  fix(scripts): helm plugins install disable verify (kubernetes-sigs#6057)
  feat(cli): remove cobra cli support (kubernetes-sigs#6034)
  fix(chart): ptsc indentation (kubernetes-sigs#6054)
  chore(deps): bump renovatebot/github-action (kubernetes-sigs#6051)
  feat(aws): enable support for NAPTR records (kubernetes-sigs#6022)
  refactor: extract normalizeDNSName to idna package for reuse (kubernetes-sigs#6043)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. chart cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. github_actions Pull requests that update GitHub Actions code lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants