Skip to content

fix(scripts): helm plugins install disable verify#6057

Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:masterfrom
vflaux:fix_script_helm_tools_install
Dec 26, 2025
Merged

fix(scripts): helm plugins install disable verify#6057
k8s-ci-robot merged 1 commit intokubernetes-sigs:masterfrom
vflaux:fix_script_helm_tools_install

Conversation

@vflaux
Copy link
Copy Markdown
Contributor

@vflaux vflaux commented Dec 26, 2025

What does it do ?

Disable helm 4 plugins install verification in scripts/helm-tools.sh.

Motivation

Plugins install fails with helm 4.

Note: this breaks install with helm 3 as --verify flag does not exists.

More

  • [c] Yes, this PR title follows Conventional Commits
  • Yes, I added unit tests
  • Yes, I updated end user documentation accordingly

@k8s-ci-robot k8s-ci-robot added scripts Issues or PRs related to internal scripts size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 26, 2025
@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 20521941146

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.005%) to 78.697%

Totals Coverage Status
Change from base Build 20519784676: 0.005%
Covered Lines: 16022
Relevant Lines: 20359

💛 - Coveralls

@ivankatliarchuk
Copy link
Copy Markdown
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 26, 2025
@ivankatliarchuk
Copy link
Copy Markdown
Member

/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ivankatliarchuk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 26, 2025
@k8s-ci-robot k8s-ci-robot merged commit 47d49ed into kubernetes-sigs:master Dec 26, 2025
20 checks passed
ivankatliarchuk added a commit to gofogo/k8s-sigs-external-dns-fork that referenced this pull request Dec 28, 2025
* master:
  somehow single test was not fixed (kubernetes-sigs#6059)
  refactore(registry): move registry selector to registry package (kubernetes-sigs#6047)
  fix(domain-exclusion): domain exclusion filter fix (kubernetes-sigs#6050)
  chore(wrapper): centralized endpoint validation (kubernetes-sigs#6041)
  test(coverage): improve code coverage for different files (kubernetes-sigs#6045)
  chore(lint): configure modernize linter (kubernetes-sigs#6035)
  docs(proposal): Gateway API annotation placement clarity proposal (kubernetes-sigs#5919)
  fix(scripts): helm plugins install disable verify (kubernetes-sigs#6057)
  feat(cli): remove cobra cli support (kubernetes-sigs#6034)
  fix(chart): ptsc indentation (kubernetes-sigs#6054)
  chore(deps): bump renovatebot/github-action (kubernetes-sigs#6051)
  feat(aws): enable support for NAPTR records (kubernetes-sigs#6022)
  refactor: extract normalizeDNSName to idna package for reuse (kubernetes-sigs#6043)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. scripts Issues or PRs related to internal scripts size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants