Skip to content

🌱 Group resources in tilt#5217

Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:masterfrom
fabriziopandini:group-resources-in-tilt
Sep 22, 2021
Merged

🌱 Group resources in tilt#5217
k8s-ci-robot merged 1 commit intokubernetes-sigs:masterfrom
fabriziopandini:group-resources-in-tilt

Conversation

@fabriziopandini
Copy link
Member

@fabriziopandini fabriziopandini commented Sep 7, 2021

What this PR does / why we need it:
This PR plays on a feature recently added in tilt that allows us to to group resources in the tilt dashboard see https://blog.tilt.dev/2021/08/09/resource-grouping.html.

I'm currently providing two different grouping strategies:

  • by controllers and local binaries
  • by provider

~~ The tricky part is that in order to get this to work nicely, we should change current default provider names, and this requires a small change to tilt_settings.json on the developer side ~~ (fixed)

I also have to investigate if this works with older releases...

@CecileRobertMichon @vincepri @sbueringer opinions?

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 7, 2021
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 7, 2021
@CecileRobertMichon
Copy link
Contributor

+1, kubernetes-sigs/cluster-api-provider-azure#1668 is doing something similar in CAPZ

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Sep 20, 2021

@fabriziopandini: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-verify b842a39 link /test pull-cluster-api-verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@fabriziopandini fabriziopandini changed the title [WIP] 🌱 Group resources in tilt 🌱 Group resources in tilt Sep 22, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 22, 2021
@fabriziopandini
Copy link
Member Author

fabriziopandini commented Sep 22, 2021

with this PR Tilt UI now looks like:
Screenshot 2021-09-22 at 12 30 27

A small change in provider's tilt-provider.json file is required to make them to plugin nicely in this UX - see changes in the doc -; however if this does not happen or users are in older versions of tilt, the UX acts mostly as of today.

@sbueringer
Copy link
Member

sbueringer commented Sep 22, 2021

Looks great!
I don't really know enough about Tiltfile syntax, but it looks correct and as it works:
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 22, 2021
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 22, 2021
@killianmuldoon
Copy link
Contributor

killianmuldoon commented Sep 22, 2021

/lgtm

Works great on my tilt setup!

@k8s-ci-robot k8s-ci-robot merged commit 3a975a3 into kubernetes-sigs:master Sep 22, 2021
@k8s-ci-robot k8s-ci-robot added this to the v0.4 milestone Sep 22, 2021
@fabriziopandini fabriziopandini deleted the group-resources-in-tilt branch September 23, 2021 11:49
pydctw pushed a commit to pydctw/cluster-api-provider-aws that referenced this pull request Sep 28, 2021
See cluster-api issue for grouping resources in Tilt, kubernetes-sigs/cluster-api#5217
bengentil added a commit to bengentil/cluster-api-provider-openstack that referenced this pull request Dec 23, 2022
Following kubernetes-sigs/cluster-api#5217,
tilt expects a label field in tilt-provider files

Signed-off-by: Benjamin Gentil <benjamin.gentil@infomaniak.com>
mnaser pushed a commit to mnaser/cluster-api-provider-openstack that referenced this pull request Mar 16, 2023
Following kubernetes-sigs/cluster-api#5217,
tilt expects a label field in tilt-provider files

Signed-off-by: Benjamin Gentil <benjamin.gentil@infomaniak.com>
pierreprinetti pushed a commit to shiftstack/cluster-api-provider-openstack that referenced this pull request Apr 22, 2024
Following kubernetes-sigs/cluster-api#5217,
tilt expects a label field in tilt-provider files

Signed-off-by: Benjamin Gentil <benjamin.gentil@infomaniak.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

Comments