-
Notifications
You must be signed in to change notification settings - Fork 287
🐛 Fix Tilt by adding CAPO label in tilt-provider.json #1430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Fix Tilt by adding CAPO label in tilt-provider.json #1430
Conversation
Following kubernetes-sigs/cluster-api#5217, tilt expects a label field in tilt-provider files Signed-off-by: Benjamin Gentil <[email protected]>
✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
|
|
Welcome @bengentil! |
|
Hi @bengentil. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
|
I don't use tilt. Can anybody else approve? |
|
I don't use it as well but seems it's pretty straightforward change given the link in commit msg /lgtm |
|
I'm going to approve this on the basis that if it breaks somebody will come and tell us about it 😂 /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bengentil, mdbooth The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
|
/test pull-cluster-api-provider-openstack-e2e-test |
What this PR does / why we need it:
Following kubernetes-sigs/cluster-api#5217, tilt expects a label field in tilt-provider files
The documentation for reference: https://cluster-api.sigs.k8s.io/developer/tilt.html#tilt-provider-configuration
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
TODOs:
/hold