Add labels for Tilt resources#1668
Conversation
|
Hi @Jont828. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Worked on this with @mboersma, there's an 'uncategorized' resource that we couldn't apply a label to. Should we leave it as is, or is there a way to handle that? |
|
/ok-to-test |
CecileRobertMichon
left a comment
There was a problem hiding this comment.
/lgtm
perhaps we can deal with the "uncategorized" resources by categorizing them into resources and adding them to a group later
|
I can open an issue to add the uncategorized CRDs to a label later on. Is this PR good to be merged? |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: devigned The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test pull-cluster-api-provider-azure-e2e |


What type of PR is this?
/kind feature
What this PR does / why we need it: Add labels for Tilt resources
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):N/A
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
TODOs:
Release note: