✨ Use grouping feature of Tilt to add CAPM3 label#385
Merged
Conversation
metal3-io-bot
added
do-not-merge/hold
furkatgofurov7
force-pushed
the
update-tilt-provider/furkat
branch
3 times, most recently
from
61cb32d to
6d18285
Compare
metal3-io-bot
added
size/M
furkatgofurov7
force-pushed
the
update-tilt-provider/furkat
branch
2 times, most recently
from
abb30c8 to
ba6f5e6
Compare
furkatgofurov7
force-pushed
the
update-tilt-provider/furkat
branch
from
ba6f5e6 to
db35b47
Compare
metal3-io-bot
added
size/S
furkatgofurov7
force-pushed
the
update-tilt-provider/furkat
branch
2 times, most recently
from
0208b11 to
9fe132c
Compare
metal3-io-bot
added
size/M
furkatgofurov7
force-pushed
the
update-tilt-provider/furkat
branch
4 times, most recently
from
d688285 to
905fc3f
Compare
furkatgofurov7
force-pushed
the
update-tilt-provider/furkat
branch
from
905fc3f to
cd60c81
Compare
This was referenced Jan 3, 2022
Member
Author
|
/hold cancel
|
metal3-io-bot
removed
the
do-not-merge/hold
Member
Author
|
/test-v1b1-integration |
kashifest
approved these changes
Jan 4, 2022
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kashifest The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
approved
Member
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Update tilt-provider.json to add CAPM3 label in Tilt UX. This grouping feature is supported in tilt version >= v0.22.2.
This patch provides two different grouping strategies:
See CAPI PR for grouping resources in Tilt.
Also, the corresponding controller and binary will be grouped under 'CAPM3' group label as shown in the local Tilt setup using BMO,CAPM3&IPAM controllers.
Related patches in: IPAM&BMO.
/hold needs local testing