Skip to content

Update tilt-provider.json to add CAPA label in Tilt#2806

Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
pydctw:update-tilt-provider
Sep 29, 2021
Merged

Update tilt-provider.json to add CAPA label in Tilt#2806
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
pydctw:update-tilt-provider

Conversation

@pydctw
Copy link
Copy Markdown
Contributor

@pydctw pydctw commented Sep 28, 2021

What type of PR is this?
/kind feature

What this PR does / why we need it:
Update tilt-provider.json to add CAPA label in Tilt UX. This grouping feature is supported in tilt version >= v0.22.2.
See cluster-api issue for grouping resources in Tilt.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Release note:

Add CAPA label in Tilt

See cluster-api issue for grouping resources in Tilt, kubernetes-sigs/cluster-api#5217
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. needs-priority cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 28, 2021
@pydctw
Copy link
Copy Markdown
Contributor Author

pydctw commented Sep 28, 2021

See Tilt UX

BEFORE the change

before

AFTER the change - with CAPA label

after

@dlipovetsky
Copy link
Copy Markdown
Contributor

/lgtm

Thanks @pydctw!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 29, 2021
@richardcase
Copy link
Copy Markdown
Member

/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: richardcase

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 29, 2021
@k8s-ci-robot k8s-ci-robot merged commit db2540b into kubernetes-sigs:main Sep 29, 2021
@k8s-ci-robot k8s-ci-robot added this to the v0.7.0 milestone Sep 29, 2021
@pydctw pydctw deleted the update-tilt-provider branch October 5, 2021 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants