Skip to content

🐛Bump CAPI to v1.0.4#1136

Merged
k8s-ci-robot merged 3 commits intokubernetes-sigs:mainfrom
shiftstack:capi-bump
Feb 10, 2022
Merged

🐛Bump CAPI to v1.0.4#1136
k8s-ci-robot merged 3 commits intokubernetes-sigs:mainfrom
shiftstack:capi-bump

Conversation

@mdbooth
Copy link
Contributor

@mdbooth mdbooth commented Feb 8, 2022

Fixes #1132

/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 8, 2022
@netlify
Copy link

netlify bot commented Feb 8, 2022 •
edited
Loading

✔️ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

🔨 Explore the source changes: 597fec7

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/6203dd336351310007696db7

😎 Browse the preview: https://deploy-preview-1136--kubernetes-sigs-cluster-api-openstack.netlify.app

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Feb 8, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mdbooth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 8, 2022
@mdbooth mdbooth mentioned this pull request Feb 8, 2022
Closed
3 tasks
sbueringer
sbueringer reviewed Feb 8, 2022
View reviewed changes
test/e2e/data/e2e_conf.yaml

images:
- name: gcr.io/k8s-staging-cluster-api/cluster-api-controller:v1.0.0
- name: gcr.io/k8s-staging-cluster-api/cluster-api-controller:v1.0.4
Copy link
Member

@sbueringer sbueringer Feb 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't be the cause of the issue but those versions should also be updated in the makefile in the test-e2e-image-prerequisites target

@apricote apricote mentioned this pull request Feb 8, 2022
Merged
3 tasks
@mdbooth
Copy link
Contributor Author

mdbooth commented Feb 8, 2022

Looks like we may also need kubernetes-sigs/cluster-api#6080.

@jichenjc jichenjc mentioned this pull request Feb 9, 2022
Merged
@mdbooth mdbooth mentioned this pull request Feb 9, 2022
Merged
sbueringer
sbueringer reviewed Feb 9, 2022
View reviewed changes
@mdbooth
Copy link
Contributor Author

mdbooth commented Feb 9, 2022

We're also waiting on kubernetes-sigs/cluster-api#6080 to merge. When it does we need to bump the sigs.k8s.io/cluster-api/test dep to include the fix.

@mdbooth mdbooth force-pushed the capi-bump branch 2 times, most recently from ef597ef to 9996f36 Compare February 9, 2022 11:50
@mdbooth
Copy link
Contributor Author

mdbooth commented Feb 9, 2022

/test pull-cluster-api-provider-openstack-e2e-test

@mdbooth
Copy link
Contributor Author

mdbooth commented Feb 9, 2022

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 9, 2022
chrischdi
chrischdi reviewed Feb 9, 2022
View reviewed changes
Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one nit: as @sbueringer mentioned:

We should also update the images here:
https://github.com/kubernetes-sigs/cluster-api-provider-openstack/blob/main/Makefile#L137

@chrischdi
Copy link
Member

chrischdi commented Feb 9, 2022

one nit: as @sbueringer mentioned:

We should also update the images here: https://github.com/kubernetes-sigs/cluster-api-provider-openstack/blob/main/Makefile#L137

adding hold for you @mdbooth to decide to either fix the Makefile in this PR or unlock CI and fix the Makefile in a separate PR

/lgtm
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 9, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 9, 2022
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 9, 2022
@mdbooth
Copy link
Contributor Author

mdbooth commented Feb 9, 2022

one nit: as @sbueringer mentioned:
We should also update the images here: https://github.com/kubernetes-sigs/cluster-api-provider-openstack/blob/main/Makefile#L137

adding hold for you @mdbooth to decide to either fix the Makefile in this PR or unlock CI and fix the Makefile in a separate PR

/lgtm /hold

Thanks, I forgot to commit this change 🤦‍♂️ Updated. It's worth getting this right first time.

@chrischdi
Copy link
Member

chrischdi commented Feb 9, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 9, 2022
@sbueringer
Copy link
Member

sbueringer commented Feb 9, 2022

/lgtm
🎉

@seanschneeweiss
Copy link
Contributor

seanschneeweiss commented Feb 9, 2022

/lgtm
Thank you @sbueringer for your support.

@jichenjc
Copy link
Contributor

jichenjc commented Feb 10, 2022

/lgtm
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 10, 2022
@k8s-ci-robot k8s-ci-robot merged commit dcd0cc0 into kubernetes-sigs:main Feb 10, 2022
@jichenjc jichenjc mentioned this pull request Feb 10, 2022
Closed
@pierreprinetti pierreprinetti deleted the capi-bump branch February 25, 2022 12:59
This was referenced Mar 8, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seanschneeweiss seanschneeweiss Awaiting requested review from seanschneeweiss

@tobiasgiese tobiasgiese Awaiting requested review from tobiasgiese

2 more reviewers

@chrischdi chrischdi chrischdi left review comments

@sbueringer sbueringer sbueringer left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@chrischdi chrischdi

@sbueringer sbueringer

@seanschneeweiss seanschneeweiss

@jichenjc jichenjc

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

clusterctl in release-0.5 CI fails with cert-manager error

6 participants

@mdbooth @k8s-ci-robot @chrischdi @sbueringer @seanschneeweiss @jichenjc