Skip to content

🐛 Delete trunk on failure#1130

Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:release-0.5from
shiftstack:cherry-pick-1095
Mar 11, 2022
Merged

🐛 Delete trunk on failure#1130
k8s-ci-robot merged 1 commit intokubernetes-sigs:release-0.5from
shiftstack:cherry-pick-1095

Conversation

@mdbooth
Copy link
Contributor

@mdbooth mdbooth commented Feb 7, 2022

Conflicts:
pkg/cloud/services/compute/instance_test.go

Unit tests have not been backported because they added test cases to
unit tests which don't exist in release-0.5.

(cherry picked from commit 28f820b)

/hold

@jichenjc @mdbooth
Delete trunk on failure
54b96b5 
Conflicts:
  pkg/cloud/services/compute/instance_test.go

  Unit tests have not been backported because they added test cases to
  unit tests which don't exist in release-0.5.

(cherry picked from commit 28f820b)
@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 7, 2022
@netlify
Copy link

netlify bot commented Feb 7, 2022 •
edited
Loading

✔️ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

🔨 Explore the source changes: 54b96b5

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/62011fe7f97c180008689ad9

😎 Browse the preview: https://deploy-preview-1130--kubernetes-sigs-cluster-api-openstack.netlify.app

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 7, 2022
@mdbooth mdbooth mentioned this pull request Feb 7, 2022
Closed
@tobiasgiese
Copy link
Member

tobiasgiese commented Feb 7, 2022

/lgtm
Thanks! :)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 7, 2022
@mdbooth
Copy link
Contributor Author

mdbooth commented Feb 7, 2022

Looks like an infra failure

/test pull-cluster-api-provider-openstack-e2e-test

@Xenwar
Copy link

Xenwar commented Feb 9, 2022

/retest

@mdbooth
Copy link
Contributor Author

mdbooth commented Feb 9, 2022

/retest

CI is broken right now. See #1136

@seanschneeweiss
Copy link
Contributor

seanschneeweiss commented Feb 9, 2022

/lgtm

@jichenjc
Copy link
Contributor

jichenjc commented Feb 21, 2022

/retest

chrischdi
chrischdi reviewed Mar 3, 2022
View reviewed changes
Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@chrischdi
Copy link
Member

chrischdi commented Mar 3, 2022

/retest

@apricote apricote mentioned this pull request Mar 10, 2022
Closed
@apricote
Copy link
Member

apricote commented Mar 11, 2022

/retest

CI should be fixed by #1169

@seanschneeweiss
Copy link
Contributor

seanschneeweiss commented Mar 11, 2022

/lgtm

@jichenjc
Copy link
Contributor

jichenjc commented Mar 11, 2022

/approve
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 11, 2022
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Mar 11, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jichenjc, mdbooth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 11, 2022
@k8s-ci-robot k8s-ci-robot merged commit 8a2816b into kubernetes-sigs:release-0.5 Mar 11, 2022
@mdbooth mdbooth deleted the cherry-pick-1095 branch December 13, 2022 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seanschneeweiss seanschneeweiss Awaiting requested review from seanschneeweiss

1 more reviewer

@chrischdi chrischdi chrischdi left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@chrischdi chrischdi

@seanschneeweiss seanschneeweiss

@tobiasgiese tobiasgiese

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@mdbooth @tobiasgiese @Xenwar @seanschneeweiss @jichenjc @chrischdi @apricote @k8s-ci-robot